Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated typechecking-with-proptypes page into Korean #78

Merged
merged 10 commits into from Apr 9, 2019
Merged

Translated typechecking-with-proptypes page into Korean #78

merged 10 commits into from Apr 9, 2019

Conversation

sukjae
Copy link
Contributor

@sukjae sukjae commented Mar 25, 2019 •
edited by taehwanno

@netlify
Copy link

netlify bot commented Mar 25, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 2affa14

https://deploy-preview-78--ko-reactjs-org.netlify.com

@hg-pyun hg-pyun added the needs review Needs review A pull request ready to be reviewed label Mar 25, 2019
hg-pyun
hg-pyun previously requested changes Mar 25, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

의견 남겨보았습니다. 확인 부탁드립니다 :)

content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
content/docs/typechecking-with-proptypes.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request Mar 26, 2019
Closed
98 tasks
@simsim0709 simsim0709 added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Mar 27, 2019
@simsim0709 simsim0709 added needs +1 approval and removed needs author response Changes requested needing author's input labels Apr 1, 2019
@simsim0709 simsim0709 self-requested a review April 1, 2019 04:23
simsim0709
simsim0709 approved these changes Apr 1, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

@simsim0709 simsim0709 dismissed hg-pyun’s stale review April 9, 2019 04:17

두 명 리뷰 되서 머지 합니다.

@simsim0709 simsim0709 merged commit f39fd6b into reactjs:master Apr 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsim0709 simsim0709 simsim0709 approved these changes

@gnujoow gnujoow gnujoow approved these changes

@hg-pyun hg-pyun hg-pyun left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sukjae @simsim0709 @hg-pyun @gnujoow @taehwanno