Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate fragments #83

Merged
merged 6 commits into from Apr 7, 2019
Merged

Translate fragments #83

merged 6 commits into from Apr 7, 2019

Conversation

yoeubi
Copy link
Contributor

@yoeubi yoeubi commented Mar 29, 2019 •
edited

@netlify
Copy link

netlify bot commented Mar 29, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit 6b860b6

https://deploy-preview-83--ko-reactjs-org.netlify.com

@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Mar 29, 2019
@tesseralis tesseralis mentioned this pull request Mar 29, 2019
Closed
98 tasks
@simsim0709 simsim0709 added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Apr 3, 2019
@yoeubi
Copy link
Contributor Author

yoeubi commented Apr 4, 2019

@simsim0709 리뷰 반영했습니다. 감사합니다.

@simsim0709 simsim0709 added needs +1 approval and removed needs author response Changes requested needing author's input labels Apr 5, 2019
simsim0709
simsim0709 approved these changes Apr 5, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다~ 👍

hg-pyun
hg-pyun approved these changes Apr 7, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taehwanno taehwanno merged commit ce55111 into reactjs:master Apr 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simsim0709 simsim0709 simsim0709 approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@yoeubi @simsim0709 @hg-pyun @taehwanno