Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

higher-order-components (partial) #187

Closed
wants to merge 27 commits into from
Closed

higher-order-components (partial) #187

wants to merge 27 commits into from

Conversation

gnujoow
Copy link
Member

@gnujoow gnujoow commented Nov 12, 2019 •
edited

Progress

  • 번역 초안 작성 (Draft translation)

번역한 부분에 대한 초안을 작성했습니다.

@netlify
Copy link

netlify bot commented Nov 12, 2019 •
edited

Deploy preview for ko-reactjs-org ready!

Built with commit ecbd21a

https://deploy-preview-187--ko-reactjs-org.netlify.app

@tesseralis tesseralis mentioned this pull request Nov 19, 2019
Closed
98 tasks
@taehwanno
Copy link
Member

@gnujoow 해당 PR의 번역 진행상황과 관련해서#1 (comment) 코멘트에 대해 응답해주실 수 있을까요?ㅎㅎ

@gnujoow
Copy link
Member Author

gnujoow commented May 14, 2020

@taehwanno 우선 진행된 부분까지 리뷰를 요청드려도 될까요?

@gnujoow gnujoow requested a review from taehwanno May 14, 2020 04:37
@hg-pyun hg-pyun added the needs review Needs review A pull request ready to be reviewed label May 16, 2020
@gnujoow gnujoow changed the title higher-order-components (wip) higher-order-components (partial) May 17, 2020
@taehwanno taehwanno self-assigned this May 18, 2020
taehwanno
taehwanno reviewed May 18, 2020
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

지금까지 번역하신 부분에 대해 리뷰드려요~!

content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
content/docs/higher-order-components.md Outdated Show resolved Hide resolved
@taehwanno taehwanno added needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels May 19, 2020
gnujoow and others added 13 commits July 23, 2020 22:16
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
e201cb1 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
bb618ac 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
e5f492b 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
171e856 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
bd6cc96 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
4576ce0 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
875d00e 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
89e651e 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
6a89704 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
11f81a4 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
b26958a 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
a62d9c1 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
0294a0c 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
gnujoow and others added 9 commits July 23, 2020 22:19
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
a541729 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
6628d0a 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
aa529f1 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
593a091 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
0dedf86 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
46999ef 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
f77be2c 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Update content/docs/higher-order-components.md
cecb0f8 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow @taehwanno
Apply suggestions from code review
7431ba9 
Co-authored-by: Taehwan Noh <taehwanno.dev@gmail.com>
@gnujoow
Copy link
Member Author

gnujoow commented Jul 23, 2020

@taehwanno 리뷰주신 내용 확인했습니다. 나머지 부분은 차주중에 마무리 하겠습니다 👍

@gnujoow gnujoow removed the needs author response Changes requested needing author's input label Jul 23, 2020
@gnujoow gnujoow requested a review from taehwanno July 23, 2020 13:23
@taehwanno taehwanno added the needs review Needs review A pull request ready to be reviewed label Aug 14, 2020
hg-pyun and others added 2 commits September 7, 2020 12:12
@taehwanno
Copy link
Member

@gnujoow 안녕하세요! 번역되지 않은 부분을 포함해서 최종 작업이 언제 마무리될 지 공유받을 수 있을까요?ㅎㅎ

@taehwanno taehwanno assigned taehwanno and unassigned taehwanno Oct 31, 2020
@taehwanno
Copy link
Member

@gnujoow 리마인드 드려요~! 진행상황 공유 부탁드릴게요 ㅎㅎ

@hg-pyun hg-pyun added no long-term response Waiting for author response for a long time needs author response Changes requested needing author's input and removed needs review Needs review A pull request ready to be reviewed labels Jan 29, 2021
@taehwanno
Copy link
Member

장기간 작업이 지속되지 않아서 다른 분께 배정되었습니다 ㅎㅎ 해당 PR은 닫도록 할게요. 양해 부탁드립니다!

Ref : #1 (comment)

@taehwanno taehwanno closed this Feb 16, 2021
@taehwanno taehwanno mentioned this pull request Feb 16, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taehwanno taehwanno Awaiting requested review from taehwanno

Assignees

@taehwanno taehwanno

Labels
needs author response Changes requested needing author's input no long-term response Waiting for author response for a long time
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gnujoow @taehwanno @hg-pyun