Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 'Context' page #129

Merged
merged 2 commits into from Oct 5, 2019
Merged

Conversation

jakubdrozdek
Copy link
Member

No description provided.

@jakubdrozdek jakubdrozdek added the needs review A pull request ready to be reviewed label Sep 8, 2019
@jakubdrozdek jakubdrozdek requested a review from a team September 8, 2019 22:53
@netlify
Copy link

netlify bot commented Sep 8, 2019

Deploy preview for pl-reactjs ready!

Built with commit e95eb1d

https://deploy-preview-129--pl-reactjs.netlify.com

// Context lets us pass a value deep into the component tree
// without explicitly threading it through every component.
// Create a context for the current theme (with "light" as the default).
// Kontekst pozwala na odczyt wartości wymaganych gdzieś głęboko w drzewie
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co powiesz na Kontekst pozwala na przekazywanie wartości głęboko do drzewa komponentów?

// and pass it to the ThemedButton. This can become painful
// if every single button in the app needs to know the theme
// because it would have to be passed through all components.
// Komponent `Toolbar` musi odbierać dodatkową właściwość "theme"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co myślisz o użyciu przyjmować zamiast odbierać?

@lekterable
Copy link
Contributor

Hej, zostawiłem kilka sugestii, które nasunęły mi się po rzuceniu na to świeżym okiem. Dzięki za to co robicie! :)

@jakubdrozdek
Copy link
Member Author

@lekterable Dzięki za sugestie. Wszystkie wrzuciłem :-)

@jakubdrozdek jakubdrozdek added the needs +1 Needs another approval before merging label Sep 15, 2019
@jakubdrozdek jakubdrozdek merged commit f2189b4 into reactjs:master Oct 5, 2019
@jakubdrozdek jakubdrozdek deleted the context branch October 5, 2019 11:45
@jakubdrozdek jakubdrozdek added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Oct 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants