Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate 'Rules of Hooks' page #54

Merged
merged 4 commits into from Mar 19, 2019
Merged

Translate 'Rules of Hooks' page #54

merged 4 commits into from Mar 19, 2019

Conversation

g12i
Copy link
Contributor

@g12i g12i commented Mar 17, 2019 •
edited

@g12i g12i added the work in progress Author opened the pull-request but it's still being worked on label Mar 17, 2019
@g12i g12i requested a review from a team March 17, 2019 19:10
@tesseralis tesseralis mentioned this pull request Mar 17, 2019
Closed
94 tasks
@netlify
Copy link

netlify bot commented Mar 17, 2019 •
edited

Deploy preview for pl-reactjs ready!

Built with commit 11190b0

https://deploy-preview-54--pl-reactjs.netlify.com

@g12i g12i added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Mar 17, 2019
@g12i g12i changed the title Translate 'Rules of Hooks' page #WIP Translate 'Rules of Hooks' page Mar 17, 2019
jakubdrozdek
jakubdrozdek requested changes Mar 17, 2019
View reviewed changes
Copy link
Member

@jakubdrozdek jakubdrozdek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Niewielkie zmiany - całość wyszła dobrze :)

@jakubdrozdek @g12i
Apply suggestions from code review
1397d4e 
Co-Authored-By: g12i <grzebieniowski@gmail.com>
@g12i g12i added the needs +1 Needs another approval before merging label Mar 18, 2019
@g12i g12i requested a review from jakubdrozdek March 18, 2019 19:51
@g12i g12i requested a review from a team March 18, 2019 19:51
jakubdrozdek
jakubdrozdek requested changes Mar 19, 2019
View reviewed changes
content/docs/hooks-rules.md Outdated Show resolved Hide resolved
@jakubdrozdek @cvqprs
Update content/docs/hooks-rules.md
11190b0 
Co-Authored-By: cvqprs <cvqprs@gmail.com>
@cvqprs cvqprs added 🌐 translated Translation is completed for this page can be merged and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Mar 19, 2019
@cvqprs cvqprs merged commit 3c37c84 into master Mar 19, 2019
@g12i g12i deleted the hooks-rules branch April 1, 2019 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cvqprs cvqprs cvqprs approved these changes

@jakubdrozdek jakubdrozdek jakubdrozdek approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@g12i @cvqprs @jakubdrozdek