Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate 'invalid-aria-prop' warning page #88

Merged
merged 2 commits into from May 20, 2019

Conversation

jakubdrozdek
Copy link
Member

@jakubdrozdek jakubdrozdek commented May 14, 2019

The translation guide says that we shouldn't translate the warning messages, because people often search for them in Google, and we want to keep the good SEO.

@jakubdrozdek jakubdrozdek added the needs review A pull request ready to be reviewed label May 14, 2019
@jakubdrozdek jakubdrozdek added this to the Other Pages milestone May 14, 2019
@jakubdrozdek jakubdrozdek requested a review from a team May 14, 2019 21:34
@netlify
Copy link

netlify bot commented May 14, 2019

Deploy preview for pl-reactjs ready!

Built with commit e9b1299

https://deploy-preview-88--pl-reactjs.netlify.com

@cvqprs cvqprs added the needs +1 Needs another approval before merging label May 16, 2019
Copy link
Member

@bartlomiejzuber bartlomiejzuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wszystko ok, proponuje jeszcze tylko dodać sugestie od @jfrej .

Co-Authored-By: Jakub Frej <jfrej@users.noreply.github.com>
@jakubdrozdek jakubdrozdek removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels May 20, 2019
@jakubdrozdek jakubdrozdek merged commit 54d7c06 into reactjs:master May 20, 2019
@jakubdrozdek jakubdrozdek deleted the warning-invalid-aria branch May 20, 2019 11:36
@jakubdrozdek jakubdrozdek added the 🌐 translated Translation is completed for this page label Jun 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants