Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation ReactDOMServer page #10

Merged
merged 15 commits into from Feb 9, 2019
Merged

Translation ReactDOMServer page #10

merged 15 commits into from Feb 9, 2019

Conversation

fjoshuajr
Copy link
Collaborator

#1

@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 8, 2019
@fjoshuajr fjoshuajr changed the title API Reference / ReactDOMServer ReactDOMServer page Feb 8, 2019
koka0012
koka0012 suggested changes Feb 8, 2019
View reviewed changes
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated
@@ -61,15 +61,15 @@ If you plan to use React on the client to make the markup interactive, do not us
ReactDOMServer.renderToNodeStream(element)
```

Render a React element to its initial HTML. Returns a [Readable stream](https://nodejs.org/api/stream.html#stream_readable_streams) that outputs an HTML string. The HTML output by this stream is exactly equal to what [`ReactDOMServer.renderToString`](#rendertostring) would return. You can use this method to generate HTML on the server and send the markup down on the initial request for faster page loads and to allow search engines to crawl your pages for SEO purposes.
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.
Renderiza um elemento React para seu HTML inicial. Retorna uma [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML dessa stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.

in my option stream is a female object, I can be wrong.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... I don't agree here. I think 'Stream' is 'Fluxo' and that's male. But we'll wait for another reviewer.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup no request inicial para ter carregamentos de página mais rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, what do you think about this one @glaucia86 and @cezaraugusto?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is already approved but I would suggest a few changes.

First, I don't think Readable Streams should be translated. It's a full term, translating it would prevent people from finding it in online searches.

Also "A saída HTML [...] é exatamente igual à" once both are female nouns (as saídas)

And I guess "motores de busca" are more standardized than "motores de pesquisa".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback @halian-vilela. could you please create a pull-request with those changes?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the feedback @halian-vilela. could you please create a pull-request with those changes?

Sure! Done: #35

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this is already approved but I would suggest a few changes.

First, I don't think Readable Streams should be translated. It's a full term, translating it would prevent people from finding it in online searches.

Also "A saída HTML [...] é exatamente igual à" once both are female nouns (as saídas)

And I guess "motores de busca" are more standardized than "motores de pesquisa".

Good catch! 👌

content/docs/reference-react-dom-server.md Show resolved Hide resolved
content/docs/reference-react-dom-server.md Show resolved Hide resolved
content/docs/reference-react-dom-server.md Show resolved Hide resolved
koka0012 and others added 2 commits February 8, 2019 18:21
@koka0012 @fjoshuajr
Update content/docs/reference-react-dom-server.md
fcda77e 
Co-Authored-By: fjoshuajr <f.joshua.jr@gmail.com>
@koka0012 @fjoshuajr
Update content/docs/reference-react-dom-server.md
85a4263 
Co-Authored-By: fjoshuajr <f.joshua.jr@gmail.com>
WendellAdriel
WendellAdriel previously requested changes Feb 8, 2019
View reviewed changes
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Outdated
@@ -61,15 +61,15 @@ If you plan to use React on the client to make the markup interactive, do not us
ReactDOMServer.renderToNodeStream(element)
```

Render a React element to its initial HTML. Returns a [Readable stream](https://nodejs.org/api/stream.html#stream_readable_streams) that outputs an HTML string. The HTML output by this stream is exactly equal to what [`ReactDOMServer.renderToString`](#rendertostring) would return. You can use this method to generate HTML on the server and send the markup down on the initial request for faster page loads and to allow search engines to crawl your pages for SEO purposes.
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup no request inicial para ter carregamentos de página mais rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.

content/docs/reference-react-dom-server.md Outdated
@@ -61,15 +61,15 @@ If you plan to use React on the client to make the markup interactive, do not us
ReactDOMServer.renderToNodeStream(element)
```

Render a React element to its initial HTML. Returns a [Readable stream](https://nodejs.org/api/stream.html#stream_readable_streams) that outputs an HTML string. The HTML output by this stream is exactly equal to what [`ReactDOMServer.renderToString`](#rendertostring) would return. You can use this method to generate HTML on the server and send the markup down on the initial request for faster page loads and to allow search engines to crawl your pages for SEO purposes.
Renderiza um elemento React para seu HTML inicial. Retorna um [Stream legível](https://nodejs.org/api/stream.html#stream_readable_streams) que gera uma string HTML. A saída HTML desse stream é exatamente igual ao que [`ReactDOMServer.renderToString`](#rendertostring) retornaria. Você pode usar este método para gerar HTML no servidor e enviar o markup para o request inicial para ter carregamentos de página rápidos e para permitir que motores de pesquisa rastreiem suas páginas para fins de SEO.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure about that, what do you think about this one @glaucia86 and @cezaraugusto?

WendellAdriel and others added 3 commits February 8, 2019 18:53
@WendellAdriel @fjoshuajr
Update content/docs/reference-react-dom-server.md
df4a675 
Co-Authored-By: fjoshuajr <f.joshua.jr@gmail.com>
@WendellAdriel @fjoshuajr
Update content/docs/reference-react-dom-server.md
f4cd86d 
Co-Authored-By: fjoshuajr <f.joshua.jr@gmail.com>
@WendellAdriel @fjoshuajr
Update content/docs/reference-react-dom-server.md
f0fae57 
Co-Authored-By: fjoshuajr <f.joshua.jr@gmail.com>
thadeu
thadeu suggested changes Feb 8, 2019
View reviewed changes
content/docs/reference-react-dom-server.md Outdated Show resolved Hide resolved
content/docs/reference-react-dom-server.md Show resolved Hide resolved
glaucia86
glaucia86 reviewed Feb 8, 2019
View reviewed changes
content/docs/reference-react-dom-server.md Outdated

- [`renderToString()`](#rendertostring)
- [`renderToStaticMarkup()`](#rendertostaticmarkup)

These additional methods depend on a package (`stream`) that is **only available on the server**, and won't work in the browser.
Estes métodos adicionais dependem do pacote (`stream`) que **só está disponível no servidor**, e não vão funcionar no navegador.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Estes métodos adicionais dependem do pacote (`stream`) que **só está disponível no servidor**, e não vão funcionar no navegador.
Estes métodos adicionais dependem do pacote (`stream`) que **só está disponível no servidor** e não vão funcionar no navegador.

@thadeu @fjoshuajr
Update content/docs/reference-react-dom-server.md
993eaea 
Co-Authored-By: fjoshuajr <f.joshua.jr@gmail.com>
cezaraugusto
cezaraugusto reviewed Feb 8, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjoshuajr solid work here! please check comments re links translation and the "stream" variation. once we all agree with changes we can approve/merge

@cezaraugusto cezaraugusto added needs resolution Something not defined that needs maintainers input and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
glaucia86
glaucia86 requested changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjoshuajr algumas alterações a serem feitas.
Quando terminar colocar como 'Resolve Conversation' que analisaremos novamente as alterações e logo aprovação da sua contribuição. Muito obrigada.

@fjoshuajr
Copy link
Collaborator Author

fjoshuajr commented Feb 9, 2019 •
edited

Ok, resolved the comments. Please have a look.
@cezaraugusto @glaucia86

glaucia86
glaucia86 approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs resolution Something not defined that needs maintainers input labels Feb 9, 2019
cezaraugusto
cezaraugusto approved these changes Feb 9, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++ thanks @fjoshuajr!

@cezaraugusto cezaraugusto merged commit 4d7484f into reactjs:master Feb 9, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 9, 2019
@tesseralis tesseralis mentioned this pull request Feb 9, 2019
Closed
90 tasks
@halian-vilela halian-vilela mentioned this pull request Feb 9, 2019
Merged
@fjoshuajr fjoshuajr deleted the reference-react-dom-server branch February 10, 2019 02:18
@fjoshuajr fjoshuajr changed the title ReactDOMServer page Translation ReactDOMServer page Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thadeu thadeu thadeu requested changes

@halian-vilela halian-vilela halian-vilela left review comments

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@koka0012 koka0012 koka0012 requested changes

@glaucia86 glaucia86 glaucia86 approved these changes

@WendellAdriel WendellAdriel WendellAdriel left review comments

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@fjoshuajr @thadeu @halian-vilela @glaucia86 @cezaraugusto @koka0012 @WendellAdriel