Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate jsx-in-depth to pt-BR #105

Merged
merged 6 commits into from Mar 9, 2019
Merged

Translate jsx-in-depth to pt-BR #105

merged 6 commits into from Mar 9, 2019

Conversation

murtinha
Copy link
Contributor

References issue number #1

@halian-vilela halian-vilela added the needs review A pull request ready to be reviewed label Feb 18, 2019
negreirosleo
negreirosleo suggested changes Feb 18, 2019
View reviewed changes
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
michellocana
michellocana suggested changes Feb 18, 2019
View reviewed changes
Copy link
Contributor

@michellocana michellocana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adicionei várias sugestões, mas sem problemas, a maioria delas são somente erros ortográficos 😄

content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela added question Further information is requested needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 18, 2019
@halian-vilela
Copy link
Collaborator

halian-vilela commented Feb 18, 2019 •
edited

@negreirosleo @michellocana @murtinha

Pessoal, obrigado pelo review!

Percebi um certo impasse ali em relação à tradução de "syntactic sugar"

Em alguns lugares ficou "açúcar sintático" e em outros a expressão foi totalmente removida e substituída por "atalho".

Creio que como estamos sempre considerando a possibilidade do usuário ler a documentação oficial e se informar o suficiente para ler em outras fontes, eu particularmente não acho que seja uma boa remover completamente a expressão. Então a versão do "atalho" não seria adequada.

Como a expressão em português (açúcar sintático), apesar de feia, já tem inclusive verbete na Wikipedia, crio que podemos utilizá-la juntamente com a expressão original entre parênteses, apenas para fins de searchability.

O que acham então de decidirmos sobre - açúcar sintático (syntactic sugar) para a tradução oficial?

Me digam o que acham q subo uma PR pro Glossário.

@michellocana
Copy link
Contributor

Não sabia que "açúcar sintático" era uma tradução reconhecida e já estava na Wikipedia, sendo assim acho que podemos usá-la sim

@negreirosleo
Copy link
Contributor

@halian-vilela eu acho válido açúcar sintático (syntactic sugar), já vi pessoas em comunidades que participo usando o termo dessa forma (porém concordo tb que é meio feio kkkkkk).

@negreirosleo negreirosleo mentioned this pull request Feb 18, 2019
Merged
michellocana
michellocana previously approved these changes Feb 19, 2019
View reviewed changes
@tesseralis tesseralis mentioned this pull request Feb 19, 2019
Closed
90 tasks
negreirosleo
negreirosleo previously approved these changes Feb 20, 2019
View reviewed changes
halian-vilela
halian-vilela requested changes Feb 26, 2019
View reviewed changes
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
@halian-vilela halian-vilela self-assigned this Feb 26, 2019
@halian-vilela @murtinha
Update content/docs/jsx-in-depth.md
f804a63 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@netlify
Copy link

netlify bot commented Feb 26, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit f804a63

https://deploy-preview-105--pt-br-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 26, 2019 •
edited

Deploy preview for pt-br-reactjs ready!

Built with commit ec6acee

https://deploy-preview-105--pt-br-reactjs.netlify.com

glaucia86
glaucia86 reviewed Mar 3, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtinha poucas mudanças a serem feitas. Realize as alterações listadas que o mais rápido possível estaremos aprovando a sua contribuição.

Muito obrigada! :)

content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
content/docs/jsx-in-depth.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs review A pull request ready to be reviewed and removed question Further information is requested labels Mar 3, 2019
@glaucia86
Copy link
Member

glaucia86 commented Mar 3, 2019 •
edited

@halian-vilela eu acho válido açúcar sintático (syntactic sugar), já vi pessoas em comunidades que participo usando o termo dessa forma (porém concordo tb que é meio feio kkkkkk).

Nesse caso, não tem como achar feio... pois no próprio wikipedia já define sobre o açúcar sintático. Cheguei a estudar sobre, nas aulas de algoritmo na Faculdade. Removendo a label question e incluindo aqui mais reviews para aprovar essa PR.

cc: @halian-vilela @eduardomoroni @cezaraugusto se puderem dar uma olhada nessa PR para que possamos aprovar o quanto antes :)

halian-vilela
halian-vilela previously approved these changes Mar 4, 2019
View reviewed changes
@halian-vilela
Copy link
Collaborator

@halian-vilela eu acho válido açúcar sintático (syntactic sugar), já vi pessoas em comunidades que participo usando o termo dessa forma (porém concordo tb que é meio feio kkkkkk).

Nesse caso, não tem como achar feito... pois no próprio wikipedia já define sobre o açúcar sintático. Cheguei a estudar sobre, nas aulas de algoritmo na Faculdade. Removendo a label question e incluindo aqui mais reviews para aprovar essa PR.

cc: @halian-vilela @eduardomoroni @cezaraugusto se puderem dar uma olhada nessa PR para que possamos aprovar o quanto antes :)

Deixei aprovado, @glaucia86, eu já tinha feito uma revisão geral, então, assim que forem feitas as suas sugestões pode mergear!

Abraços!

@glaucia86
Copy link
Member

@murtinha só fazer as alterações necessárias que logo em seguida aprovaremos a sua excelente contribuição! :)

Quando concluir nos sinalize com cc: @glaucia86 ou @halian-vilela

@jhonmike jhonmike removed the needs review A pull request ready to be reviewed label Mar 6, 2019
@glaucia86 @murtinha
Update content/docs/jsx-in-depth.md
a289fad 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@murtinha murtinha dismissed stale reviews from halian-vilela via a289fad March 8, 2019 12:06
@murtinha
Apply suggestions from code review
ec6acee 
Co-Authored-By: murtinha <ericmurta@hotmail.com>
@murtinha
Copy link
Contributor Author

murtinha commented Mar 8, 2019

Desculpa a demora @glaucia86 , estava viajando, Obrigado pelo review

@jhonmike jhonmike added needs review A pull request ready to be reviewed and removed needs author response Changes requested needing author's input labels Mar 8, 2019
@murtinha
Copy link
Contributor Author

murtinha commented Mar 9, 2019

@halian-vilela

glaucia86
glaucia86 approved these changes Mar 9, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@murtinha muito obrigada pela sua excelente contribuição!

LGTM 👍

cc: @halian-vilela @jhonmike só aprovar! :)

@glaucia86
Copy link
Member

bitmoji

cc: @murtinha muito obrigada pela sua contribuição.

cc: @halian-vilela @jhonmike só aprovar e mergear! :)

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed labels Mar 9, 2019
@jhonmike jhonmike merged commit 69168a0 into reactjs:master Mar 9, 2019
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@jhonmike jhonmike jhonmike approved these changes

@halian-vilela halian-vilela halian-vilela left review comments

@michellocana michellocana michellocana left review comments

@negreirosleo negreirosleo negreirosleo left review comments

Assignees

@halian-vilela halian-vilela

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@murtinha @halian-vilela @michellocana @negreirosleo @glaucia86 @jhonmike