Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation for Using the State Hook #108

Merged
merged 16 commits into from Mar 6, 2019
Merged

Conversation

vinicius98s
Copy link
Contributor

#1

thadeu
thadeu previously approved these changes Feb 18, 2019
content/docs/hooks-state.md Outdated Show resolved Hide resolved
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
@@ -28,11 +28,11 @@ function Example() {
}
```

We'll start learning about Hooks by comparing this code to an equivalent class example.
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo de classe equivalente.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que seria melhor alterar para =>

Suggested change
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente utilizando classe.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Achei de classe equivalente um pouco confuso.

@Lukyhenson gostei da sugestão.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Também achei confuso, acho que com o utilizando fica mais claro o q queremos fazer

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Talvez fique legal também: Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a um componente de classe.

Copy link
Contributor

@abnersajr abnersajr Feb 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Vamos começar a aprender sobre Hooks comparando este código com um exemplo equivalente utilizando Class.

ou

Suggested change
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Vamos começar a aprender sobre Hooks comparando este código com um exemplo equivalente utilizando classe.

Sugiro a primeira opção, deixar o termo Class que é amplamente conhecido e utilizado. E também assim evita o outro significado da palavra classe em PT.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sobre o ponto do aprendendo essa seria a tradução literal de learning. No entanto fica melhor da forma sugerida acima.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

acho q nao teria problema usar classe ja que deixa implicito o termo class do javascript, na minha opinião a segunda opção faz mais sentido pra mim 😄

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

O termo classe é uma tradução recomendada aqui e acho que já está bem padronizado, sobre o learning tem total razão.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

então assim fica melhor mesmo.

Suggested change
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Vamos começar a aprender sobre Hooks comparando este código com um exemplo equivalente utilizando classe.

content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 19, 2019
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
@@ -28,11 +28,11 @@ function Example() {
}
```

We'll start learning about Hooks by comparing this code to an equivalent class example.
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Acho que seria melhor alterar para =>

Suggested change
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente a classe.
Vamos começar aprendendo sobre Hooks comparando este código com um exemplo equivalente utilizando classe.

murtinha and others added 3 commits February 19, 2019 13:30
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
@halian-vilela halian-vilela added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 20, 2019
vinicius98s and others added 2 commits February 21, 2019 13:16
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit 573e4f7

https://deploy-preview-108--pt-br-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit 889841b

https://deploy-preview-108--pt-br-reactjs.netlify.com

@netlify
Copy link

netlify bot commented Feb 21, 2019

Deploy preview for pt-br-reactjs ready!

Built with commit 13b462d

https://deploy-preview-108--pt-br-reactjs.netlify.com

Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinicius98s poucas mudanças a serem feitas. Realize as alterações para que logo em seguida possamos aprovar a sua contribuição.

Muito obrigada.

cc: @tibuurcio @halian-vilela @eduardomoroni @cezaraugusto Deem uma olhada nessa PR tbm. Pouca coisa para alterar.. Assim que o autor fizer as alterações, podem aprovar :)

content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
content/docs/hooks-state.md Outdated Show resolved Hide resolved
glaucia86 and others added 7 commits March 4, 2019 19:43
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
Co-Authored-By: vinicius98s <vinicius.2010.s@gmail.com>
@vinicius98s
Copy link
Contributor Author

@glaucia86 Alterações concluídas!

Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vinicius98s Contribuição aprovada!
Queremos agradecer pela sua excelente contribuição! :)

LGTM 👍

cc: @halian-vilela mais do que revisado. Pode aprovar e mergear! ;)

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Mar 5, 2019
@jhonmike jhonmike merged commit d905fdb into reactjs:master Mar 6, 2019
@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Mar 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants