Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of the "Handling Events" page #3

Merged
merged 14 commits into from Feb 8, 2019
Merged

Translation of the "Handling Events" page #3

merged 14 commits into from Feb 8, 2019

Conversation

iagobruno
Copy link

#1

eduardomoroni
eduardomoroni approved these changes Feb 8, 2019
View reviewed changes
content/docs/handling-events.md Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Show resolved Hide resolved
@eduardomoroni eduardomoroni mentioned this pull request Feb 8, 2019
Closed
WendellAdriel
WendellAdriel previously requested changes Feb 8, 2019
View reviewed changes
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
@WendellAdriel
Copy link
Member

Also, please don't forget to take a look at #4 when translating!!!

@glaucia86 glaucia86 added the needs review A pull request ready to be reviewed label Feb 8, 2019
glaucia86
glaucia86 previously requested changes Feb 8, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some few changes

cc: @eduardomoroni @httpiago

glaucia86 and others added 7 commits February 8, 2019 12:23
WendellAdriel
WendellAdriel reviewed Feb 8, 2019
View reviewed changes
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
content/docs/handling-events.md Outdated Show resolved Hide resolved
Iago Bruno and others added 4 commits February 8, 2019 13:35
docs: Revert translation "retorno da chamada" to "callback"
ffe8b6d 
as described in Glossary and Style Guide
@WendellAdriel
docs: Replace "tratamento" to "manipular" in handling-events.md
05e72ff 
Co-Authored-By: httpiago <httpiago@gmail.com>
@WendellAdriel
docs: little correction in handling-events.md
70c9856 
"Em React" -> "No React"

Co-Authored-By: httpiago <httpiago@gmail.com>
@WendellAdriel
docs: change the conjugation of word "precisa" in handling-events.md
f88e733 
Co-Authored-By: httpiago <httpiago@gmail.com>
@glaucia86
Copy link
Member

@httpiago assim que for corrigindo os code reviews, peço por gentileza para que possa marcar como 'Resolve Conversation', blz?

cezaraugusto
cezaraugusto approved these changes Feb 8, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@httpiago thanks for taking time to do this. great work! ++

@cezaraugusto cezaraugusto dismissed stale reviews from glaucia86 and WendellAdriel February 8, 2019 23:20

feedback addressed

@cezaraugusto cezaraugusto merged commit e4f9dbc into reactjs:master Feb 8, 2019
@tesseralis tesseralis mentioned this pull request Feb 8, 2019
Closed
90 tasks
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs review A pull request ready to be reviewed labels Feb 8, 2019
rickhanlonii added a commit that referenced this pull request Apr 19, 2023
@rickhanlonii @gaearon
Fix alternate lang tags (#3)
9deda00 
* Fix alternate lang tags

* prettier

* Scope down the change

---------

Co-authored-by: Dan Abramov <dan.abramov@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eduardomoroni eduardomoroni eduardomoroni approved these changes

@glaucia86 glaucia86 glaucia86 left review comments

@victorsilent victorsilent victorsilent left review comments

@WendellAdriel WendellAdriel WendellAdriel left review comments

@cezaraugusto cezaraugusto cezaraugusto approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@iagobruno @WendellAdriel @glaucia86 @eduardomoroni @cezaraugusto @victorsilent