Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate state and lifecycle page #39

Merged
merged 11 commits into from Feb 11, 2019
Merged

Translate state and lifecycle page #39

merged 11 commits into from Feb 11, 2019

Conversation

jhonmike
Copy link
Member

@jhonmike jhonmike commented Feb 9, 2019

#1

Sections:

  • Intro to State and Lifecycle
  • Converting a Function to a Class
  • Adding Local State to a Class
  • Adding Lifecycle Methods to a Class
  • Using State Correctly
  • The Data Flows Down

@fjoshuajr fjoshuajr added the work in progress Author opened the pull-request but it's still being worked on label Feb 9, 2019
@fjoshuajr fjoshuajr changed the title Translate state and lifecycle page [WIP] Translate state and lifecycle page Feb 9, 2019
@jhonmike jhonmike changed the title [WIP] Translate state and lifecycle page Translate state and lifecycle page Feb 9, 2019
@tibuurcio
Copy link
Collaborator

tibuurcio commented Feb 9, 2019

Hi @jhonmike, thank you for taking the time to contribute to translating the docs 👍

Just to give you a heads up, I think as per #4 we shouldn't translate state to estado since it refers to such an important concept in React.

In some other PR's I'm also seeing it like: estado (state)

@cezaraugusto cezaraugusto added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 9, 2019
@cezaraugusto
Copy link
Member

@tibuurcio what do you think about using estado (_state_)? I personally like this way

@tibuurcio
Copy link
Collaborator

tibuurcio commented Feb 9, 2019

@cezaraugusto I personally think leaving just state is better, but I don't think estado (state) is bad in any way. Also, you have a lot more experience in this than I do 😆.

Maybe I'm just used to see it being written as state in english articles that it feels strange to translate probably the biggest concept (along with props) in React's API.

@jhonmike
Copy link
Member Author

jhonmike commented Feb 9, 2019

Also I was thinking, I think it could be state only, similar to props @cezaraugusto @tibuurcio

@halian-vilela
Copy link
Collaborator

@tibuurcio what do you think about using estado (_state_)? I personally like this way

I think that state can represent two different things and should be treated acordingly...

When representing the current state of the application, as a snapshot in time, I don't think it loses semantic value if we translate it to "estado".

I guess it only loses value when it's talking about state as a property of react and all that its concerned with. In this case I think we could use it without translation.

Makes sense?

@tibuurcio
Copy link
Collaborator

@halian-vilela It makes sense, indeed :)

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
halian-vilela
halian-vilela previously approved these changes Feb 10, 2019
Copy link
Collaborator

@halian-vilela halian-vilela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Só mudar essa última coisinhas sobre o gênero das funções.

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@jhonmike
Copy link
Member Author

jhonmike commented Feb 11, 2019

Esse force foi apenas um update da master com um --rebase no final ;)

Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

obrigado @jhonmike! pedi uns ajustes: um erro de ortografia e para capitalizar as palavras dos títulos, como original. De resto tá ótimo pra mim.

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@cezaraugusto cezaraugusto added needs author response Changes requested needing author's input and removed feedback addressed labels Feb 11, 2019
@cezaraugusto cezaraugusto removed the needs review A pull request ready to be reviewed label Feb 11, 2019
@WendellAdriel WendellAdriel added needs +1 Needs another approval before merging feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jhonmike

LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 dismissed cezaraugusto’s stale review February 11, 2019 16:44

WendellAdriel e eu já realizamos o review desse PR e as alterações solicitadas já foram feitas.

@glaucia86 glaucia86 merged commit afbb698 into reactjs:master Feb 11, 2019
@glaucia86 glaucia86 added 🌐 translated Translation is completed for this page and removed feedback addressed needs +1 Needs another approval before merging labels Feb 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants