Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translated unknown-prop page to PT-BR. #44

Merged
merged 5 commits into from Feb 10, 2019
Merged

Translated unknown-prop page to PT-BR. #44

merged 5 commits into from Feb 10, 2019

Conversation

crisgon
Copy link
Contributor

@crisgon crisgon commented Feb 9, 2019

No description provided.

@crisgon crisgon mentioned this pull request Feb 9, 2019
Closed
90 tasks
@cezaraugusto cezaraugusto added the needs review A pull request ready to be reviewed label Feb 9, 2019
fjoshuajr
fjoshuajr requested changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check the comments, please.

content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
content/warnings/unknown-prop.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
fjoshuajr and others added 4 commits February 10, 2019 00:00
@fjoshuajr @crisgon
Update content/warnings/unknown-prop.md
f2b211b 
Co-Authored-By: crisgon <kristiano.gon@gmail.com>
@crisgon
Update content/warnings/unknown-prop.md
470c22a 
Co-Authored-By: crisgon <kristiano.gon@gmail.com>
@fjoshuajr @crisgon
Update content/warnings/unknown-prop.md
40e87cf 
Co-Authored-By: crisgon <kristiano.gon@gmail.com>
@fjoshuajr @crisgon
Update content/warnings/unknown-prop.md
3e3377d 
Co-Authored-By: crisgon <kristiano.gon@gmail.com>
@crisgon
Copy link
Contributor Author

crisgon commented Feb 10, 2019

Check the comments, please.

Done!

fjoshuajr
fjoshuajr approved these changes Feb 10, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✌

@fjoshuajr fjoshuajr added needs +1 Needs another approval before merging and removed needs author response Changes requested needing author's input labels Feb 10, 2019
cezaraugusto
cezaraugusto approved these changes Feb 10, 2019
View reviewed changes
Copy link
Member

@cezaraugusto cezaraugusto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@cezaraugusto cezaraugusto merged commit 720d98f into reactjs:master Feb 10, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhonmike jhonmike jhonmike left review comments

@cezaraugusto cezaraugusto cezaraugusto approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@crisgon @jhonmike @cezaraugusto @fjoshuajr