Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation: Context #55

Merged
merged 5 commits into from Feb 12, 2019
Merged

Translation: Context #55

merged 5 commits into from Feb 12, 2019

Conversation

jancassio
Copy link
Contributor

No description provided.

@jancassio jancassio closed this Feb 10, 2019
@jancassio jancassio reopened this Feb 10, 2019
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 10, 2019
rafael-vitor
rafael-vitor reviewed Feb 10, 2019
View reviewed changes
Copy link
Contributor

@rafael-vitor rafael-vitor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jancassio fiz algumas sugestões. Bom trabalho!

glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jancassio

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
glaucia86
glaucia86 requested changes Feb 10, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jancassio tudo que tiver 'Context' coloque sempre assim: Contexto (context), okay?

content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
content/docs/context.md Outdated Show resolved Hide resolved
@glaucia86
Copy link
Member

@jancassio

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar novamente a tradução e enfim, aprovar o seu PR. Muito obrigada!

Assim que você concluir as suas mudanças, marque como 'Resolve Conversation' e altere para a label: 'changes already resolved it - translator'.
Muito obrigada pela sua contribuição! 😄

@jancassio
Copy link
Contributor Author

@glaucia86 revisão ta feita, só não consigo alterar a label por que não estou como contribuidor deste projeto (eu acho).

@WendellAdriel WendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

cc: @cezaraugusto @WendellAdriel @fjoshuajr podem aprovar.

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 12, 2019
fjoshuajr
fjoshuajr approved these changes Feb 12, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito bom! 🎉🎉

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 12, 2019
@tesseralis tesseralis mentioned this pull request Feb 12, 2019
Closed
90 tasks
@fjoshuajr fjoshuajr merged commit 639c06a into reactjs:master Feb 12, 2019
@jancassio
Copy link
Contributor Author

iiiieeeeyyyyy 🎉🎉🎉
Muito obrigado gente.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafael-vitor rafael-vitor rafael-vitor left review comments

@glaucia86 glaucia86 glaucia86 approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@jancassio @glaucia86 @fjoshuajr @rafael-vitor @WendellAdriel