Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate: Api Reference Glossary #63

Merged
merged 10 commits into from Feb 12, 2019

Conversation

evaldosantos
Copy link
Contributor

No description provided.

@tibuurcio tibuurcio added the needs review A pull request ready to be reviewed label Feb 10, 2019
@evaldosantos
Copy link
Contributor Author

Acho que poderíamos colocar esses termos na issue de Glossário (https://github.com/reactjs/pt-BR.reactjs.org/blob/master/GLOSSARY.md):

  • single-page
  • readonly
  • input?

Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evaldosantos muito obrigado pela sua ajuda mestre.
Links em markdown não podem ter espaço separando a palavra do link, isso vai causar este resultado.
image

Tu poderia acertas esses espaços por gentileza?
Fora isso, da uma olhada nas sugestões que fiz, todas elas são opcionais, caso alguma não faça sentido, marque a conversa como resolvida que eu mergeio :)

Valeu

content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
content/docs/reference-glossary.md Outdated Show resolved Hide resolved
@eduardomoroni eduardomoroni added needs author response Changes requested needing author's input and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@eduardomoroni
Copy link
Member

eduardomoroni commented Feb 10, 2019

Ahhh e após altere a label deste PR para
image

eduardomoroni and others added 8 commits February 10, 2019 13:17
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
Co-Authored-By: evaldosantos <evaldojunior@edu.unifor.br>
@evaldosantos
Copy link
Contributor Author

Obrigado @eduardomoroni pelo review :)

Ahhh e após altere a label deste PR para
image

Acredito que não posso mudar as labels.

@evaldosantos
Copy link
Contributor Author

@eduardomoroni @LeoMosiah @tibuurcio Acredito que finalizei todas as alterações, mas não consigo mudar a label deste PR.

@tibuurcio tibuurcio added feedback addressed and removed needs author response Changes requested needing author's input labels Feb 11, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed labels Feb 12, 2019
@thadeu
Copy link
Contributor

thadeu commented Feb 12, 2019

@evaldosantos não esqueça de marcar como Resolve Conversation tudo que já foi resolvido. Obrigado

@evaldosantos
Copy link
Contributor Author

@evaldosantos muito obrigado pela sua ajuda mestre.
Links em markdown não podem ter espaço separando a palavra do link, isso vai causar este resultado.
image

Tu poderia acertas esses espaços por gentileza?
Fora isso, da uma olhada nas sugestões que fiz, todas elas são opcionais, caso alguma não faça sentido, marque a conversa como resolvida que eu mergeio :)

Valeu

Essa alteração já foi resolvida @thadeu, inclusive aceitei o commit que o @eduardomoroni fez e marquei como resolvido.

Copy link
Member

@eduardomoroni eduardomoroni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Showw!
Valeu irmão.

@eduardomoroni eduardomoroni merged commit 4146e0c into reactjs:master Feb 12, 2019
@cezaraugusto cezaraugusto added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants