Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate javascript-in-jsx-with-curly-braces.md #674

Merged
merged 22 commits into from
May 2, 2023
Merged

Translate javascript-in-jsx-with-curly-braces.md #674

merged 22 commits into from
May 2, 2023

Conversation

roccomaniscalco
Copy link
Contributor

Issue: Tradução da documentação para pt-br (Translation Progress) #555

Dúvidas que eu tenho:

Thank you for taking the time to review!

@roccomaniscalco
first pass
ca6dce5 
• deveria ser chamado "string" ou "cadeia de caracteres" ?
• deveria ser chamado "chaves duplas" or something more fun like "double curlies" was ?
@roccomaniscalco
improve word choice
47b0339 
• replace uses of "marca" with "tag" (reactjs#657 (comment))
@TarsiSurdi
Copy link
Contributor

Issue: Tradução da documentação para pt-br (Translation Progress) #555

Dúvidas que eu tenho:

* Deveria ser traduzido `string` ou `cadeia de caracteres`?

* Deveria ser traduzido `chaves duplas` ou algo mais divertido como `double curlies` era?

* `Bloco de tags` faz sentido? [docs(pt-br): translate writing-markup-with-jsx page #657 (comment)](https://github.com/reactjs/pt-br.react.dev/pull/657#discussion_r1178522055)

Thank you for taking the time to review!

  • String não deve ser traduzido por ser tratar de um termo técnico, como especificado pelo GLOSSARY;
  • Definitivamente chaves duplas é mais amigável ao leitor brasileiro;
  • Acho que bloco de tags está tranquilo, dependendo do contexto.

@TarsiSurdi
Copy link
Contributor

Acabei de começar a revisão e notei que você não traduziu o título da página JavaScript in JSX with Curly Braces na linha 3 do markup.

TarsiSurdi
TarsiSurdi suggested changes May 1, 2023
View reviewed changes
Copy link
Contributor

@TarsiSurdi TarsiSurdi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sugestões de edições à tradução.

A maioria dela cursa apenas com as flexões apropriadas para tratar JSX no feminino, visto que seu sujeito oculto é "a sintaxe" em grande parte dos contextos.

src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
src/content/learn/javascript-in-jsx-with-curly-braces.md Outdated Show resolved Hide resolved
@jhonmike jhonmike added the needs author response Changes requested needing author's input label May 2, 2023
@jhonmike jhonmike mentioned this pull request May 2, 2023
Open
roccomaniscalco and others added 8 commits May 2, 2023 11:52
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
c0b458f 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
ed309dd 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
741bb44 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
666f9dd 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
98a0f33 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
3e02a84 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
39126aa 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
0be37cd 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
roccomaniscalco and others added 10 commits May 2, 2023 11:55
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
259d7dc 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
1a64b84 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
b291ee3 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
b1f729d 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
efc9b8c 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
1d45605 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
a9f2fe7 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
356df46 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
9371945 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
349c54a 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
@roccomaniscalco @TarsiSurdi
Update src/content/learn/javascript-in-jsx-with-curly-braces.md
7cf6ea2 
Co-authored-by: Tarcísio Surdi <tarsisurdi@gmail.com>
jhonmike
jhonmike approved these changes May 2, 2023
View reviewed changes
Copy link
Member

@jhonmike jhonmike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jhonmike jhonmike added 🌐 translated Translation is completed for this page and removed needs author response Changes requested needing author's input labels May 2, 2023
@github-actions
Copy link

github-actions bot commented May 2, 2023

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@jhonmike jhonmike merged commit 18e42f7 into reactjs:main May 2, 2023
4 checks passed
@augustodg2 augustodg2 mentioned this pull request May 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TarsiSurdi TarsiSurdi TarsiSurdi requested changes

@jhonmike jhonmike jhonmike approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@roccomaniscalco @TarsiSurdi @jhonmike