Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Error Boundaries #73

Merged
merged 3 commits into from Feb 12, 2019
Merged

Translate Error Boundaries #73

merged 3 commits into from Feb 12, 2019

Conversation

fmoliveira
Copy link
Contributor

#1

@fmoliveira fmoliveira mentioned this pull request Feb 11, 2019
Closed
murtinha
murtinha reviewed Feb 11, 2019
View reviewed changes
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
content/docs/error-boundaries.md Outdated Show resolved Hide resolved
@fjoshuajr fjoshuajr added needs review A pull request ready to be reviewed needs author response Changes requested needing author's input labels Feb 11, 2019
murtinha and others added 2 commits February 11, 2019 10:58
@murtinha @fmoliveira
Fix typo on error boundaries.
8e64861 
Co-Authored-By: fmoliveira <contato@fmoliveira.com.br>
@murtinha @fmoliveira
Change 'cryptic' translation to a more usual synonym.
757c135 
Co-Authored-By: fmoliveira <contato@fmoliveira.com.br>
@fmoliveira
Copy link
Contributor Author

Thanks for the review @murtinha ! I've fixed the requested changes. cc @fjoshuajr

@WendellAdriel WendellAdriel added feedback addressed and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Feb 11, 2019
glaucia86
glaucia86 approved these changes Feb 12, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
Queremos agradecer pela sua excelente contribuição! Muito obrigada!

@glaucia86 glaucia86 added needs review A pull request ready to be reviewed needs +1 Needs another approval before merging and removed feedback addressed labels Feb 12, 2019
fjoshuajr
fjoshuajr approved these changes Feb 12, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✨✨

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs review A pull request ready to be reviewed labels Feb 12, 2019
@fjoshuajr fjoshuajr merged commit 1dfe1db into reactjs:master Feb 12, 2019
@tesseralis tesseralis mentioned this pull request Feb 12, 2019
Closed
90 tasks
@fmoliveira fmoliveira deleted the error-boundaries branch February 12, 2019 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murtinha murtinha murtinha left review comments

@glaucia86 glaucia86 glaucia86 approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees
No one assigned
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fmoliveira @glaucia86 @fjoshuajr @murtinha @WendellAdriel