Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding PT-BR to Accessibility page #74

Merged
merged 9 commits into from Feb 14, 2019

Conversation

LucasVilela
Copy link

PT-BR to Accessibility page

@LucasVilela LucasVilela changed the title Adding PT-BR to acessibility page Adding PT-BR to Accessibility page Feb 11, 2019
@fjoshuajr fjoshuajr added the needs review A pull request ready to be reviewed label Feb 11, 2019
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
@WendellAdriel WendellAdriel added the needs author response Changes requested needing author's input label Feb 11, 2019
Drieger and others added 3 commits February 12, 2019 06:56
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasVilela

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize para que possamos analisar. Muito obrigada pela sua contribuição.

content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
content/docs/accessibility.md Outdated Show resolved Hide resolved
glaucia86 and others added 5 commits February 12, 2019 18:27
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
Co-Authored-By: LucasVilela <lucas@madecomfy.com.au>
@LucasVilela
Copy link
Author

@glaucia86 Obrigado pelas correções, todos as alterações sugeridas foram validas e aceitas !

@eduardomoroni eduardomoroni added feedback addressed and removed needs author response Changes requested needing author's input needs review A pull request ready to be reviewed labels Feb 12, 2019
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@LucasVilela

LGTM 👍
Muito obrigada pela sua contribuição!

cc: @fjoshuajr @WendellAdriel @eduardomoroni @cezaraugusto só aprovar. Mais do que revisado.

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed feedback addressed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀

@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging labels Feb 14, 2019
@fjoshuajr fjoshuajr merged commit 60fd490 into reactjs:master Feb 14, 2019
@omurilo
Copy link

omurilo commented Mar 5, 2019

Logo no início está faltando uma tradução. Uma linha só:

The Web Content Accessibility Guidelines provides guidelines for creating accessible web sites.

Minha sugestão:

Diretrizes para criação de sites acessíveis são fornecidas pela Web Content Accessibility Guidelines.

Gostaria de sugerir outras correções na página também, levando em consideração alguns erros de escrita, como:

Usando os corretamente elementos HTML para reforçar o significado da informação em nossos sites, muitas vezes a acessibilidade pode vir gratuitamente.

onde deveria ser:

Usando corretamente os elementos HTML para reforçar o significado da informação em nossos sites, muitas vezes a acessibilidade pode vir gratuitamente.

e também:

Todos os elements de um formulário HTML, como <input> and <textarea>, precisam ser routalados.

que seria:

Todos os elements de um formulário HTML, como <input> e <textarea>, precisam ser routalados.

@fjoshuajr
Copy link
Collaborator

Obrigado pela atenção @murilokaos.
Submeta uma PR com as correções 🙂

@omurilo
Copy link

omurilo commented Mar 5, 2019

Obrigado pela atenção @murilokaos.
Submeta uma PR com as correções

Opa, assim que possível o farei.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌐 translated Translation is completed for this page
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants