Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rules / Hooks reference #76

Merged
merged 14 commits into from Feb 14, 2019
Merged

Rules / Hooks reference #76

merged 14 commits into from Feb 14, 2019

Conversation

thadeu
Copy link
Contributor

@thadeu thadeu commented Feb 11, 2019

No description provided.

@WendellAdriel WendellAdriel added the needs review A pull request ready to be reviewed label Feb 11, 2019
glaucia86
glaucia86 requested changes Feb 12, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thadeu

Algumas alterações a serem feitas. Pedimos que faça os ajustes e logo iremos aprovar a sua contribuição.
Pedimos que, conforme for realizando os acertos que marque como 'Resolve Conversation' e nos sinalize.

content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Show resolved Hide resolved
content/docs/hooks-reference.md Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
content/docs/hooks-reference.md Outdated Show resolved Hide resolved
@glaucia86 glaucia86 added needs author response Changes requested needing author's input needs review A pull request ready to be reviewed and removed needs review A pull request ready to be reviewed labels Feb 12, 2019
@thadeu
Copy link
Contributor Author

thadeu commented Feb 12, 2019

@glaucia86 tudo certo.. muito obrigado! No entanto, me parece que o texto de referência deste projeto ao Hooks Reference, não está totalmente atualizado.

@eduardomoroni eduardomoroni added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed needs author response Changes requested needing author's input labels Feb 12, 2019
@cezaraugusto cezaraugusto added needs rebase and removed needs +1 Needs another approval before merging labels Feb 13, 2019
@cezaraugusto
Copy link
Member

@thadeu pode fazer um rebase?

@thadeu
Copy link
Contributor Author

thadeu commented Feb 13, 2019

@thadeu pode fazer um rebase?

@cezaraugusto Sim! claro.

@fjoshuajr fjoshuajr added 💪 long page - more than 100 lines Long page needs review A pull request ready to be reviewed labels Feb 13, 2019
@thadeu
Copy link
Contributor Author

thadeu commented Feb 14, 2019

@cezaraugusto no conflicts in the branch.

glaucia86
glaucia86 approved these changes Feb 14, 2019
View reviewed changes
Copy link
Member

@glaucia86 glaucia86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@thadeu

LGTM 👍
Muito obrigada pela sua contribuição!

cc: @fjoshuajr @WendellAdriel @eduardomoroni @cezaraugusto só aprovar.

@glaucia86 glaucia86 added needs +1 Needs another approval before merging and removed needs review A pull request ready to be reviewed 💪 long page - more than 100 lines Long page labels Feb 14, 2019
@fjoshuajr fjoshuajr added 🌐 translated Translation is completed for this page and removed needs +1 Needs another approval before merging needs rebase labels Feb 14, 2019
fjoshuajr
fjoshuajr approved these changes Feb 14, 2019
View reviewed changes
Copy link
Collaborator

@fjoshuajr fjoshuajr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🎉

@fjoshuajr fjoshuajr merged commit ce6c5b4 into reactjs:master Feb 14, 2019
@tesseralis tesseralis mentioned this pull request Feb 14, 2019
Closed
90 tasks
@halian-vilela halian-vilela mentioned this pull request Feb 21, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glaucia86 glaucia86 glaucia86 approved these changes

@fjoshuajr fjoshuajr fjoshuajr approved these changes

Assignees

@glaucia86 glaucia86

Labels
🌐 translated Translation is completed for this page
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@thadeu @cezaraugusto @glaucia86 @fjoshuajr @eduardomoroni @WendellAdriel