Translation of the "JS Environment Requirements " page #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koka0012
changed the title
glaucia86
reviewed
Feb 8, 2019
glaucia86
added
work in progress
|
Changes made @glaucia86 |
cezaraugusto
requested changes
Feb 8, 2019
jhonmike
reviewed
Feb 8, 2019
| @@ -18,13 +18,13 @@ import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
|
|
|||
| ReactDOM.render( | |||
| <h1>Hello, world!</h1>, | |||
| <h1>Olá, mundo!</h1>, | |||
There was a problem hiding this comment.
Glossary and Style Guide
...
- Leave code blocks untranslated. (It is usually OK to translate comments inside them.)
There was a problem hiding this comment.
thanks for the input. I think for this case specifically it's ok to translate strings inside HTML/JSX elements as it doesn't change any structure/logic. I'll update the glossary
cezaraugusto
approved these changes
Feb 8, 2019
| @@ -18,13 +18,13 @@ import React from 'react'; | |||
| import ReactDOM from 'react-dom'; | |||
|
|
|||
| ReactDOM.render( | |||
| <h1>Hello, world!</h1>, | |||
| <h1>Olá, mundo!</h1>, | |||
There was a problem hiding this comment.
thanks for the input. I think for this case specifically it's ok to translate strings inside HTML/JSX elements as it doesn't change any structure/logic. I'll update the glossary
glaucia86
approved these changes
Feb 8, 2019
|
cc @glaucia86 I guess all feedback was addressed please merge if it looks ok to you |
|
@cezaraugusto done! :) |
90 tasks
cezaraugusto
added
🌐 translated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1