Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have a look at romeovs/react-a11y, possibly for v1.0.0 #120

Closed
romeovs opened this issue Apr 16, 2016 · 2 comments
Closed

Have a look at romeovs/react-a11y, possibly for v1.0.0 #120

romeovs opened this issue Apr 16, 2016 · 2 comments

Comments

@romeovs
Copy link
Collaborator

romeovs commented Apr 16, 2016

Hi guys,

I really like the work you've been doing on react-a11y. I think the problem it
is trying to solve is an important one and I think it does a great job solving
it.

However, after looking at the source code, I felt the project could move faster
if it were built with more modularity in mind.

After forking the project to work on some of the open issues (I've created some
pull requests), I felt that it would be more feasible to do a total rewrite
(starting from you code) than to attempt to change the architecture bit by bit.
So I did!

Take a look at my repo. You'll see I've
changed quite a bit. I've tried to document the changes as clearly as possible in the
README, but here is the gist of it:

I incorporated a lot of your code of course, mainly from your rules (as well as
some rules from eslint-plugin-jsx-a11y).

I hope you like the work I did. It would be nice if we could find a way for
these changes to be moved back into this fork (as a next major version for
example). I would love to remain a contributor so I can help maintain the new
codebase.

Please let me know if you feel the same about merging the forks, and how you
think we should go about it!

Anyways, keep up the good work!

@gf3
Copy link

gf3 commented Apr 21, 2016

wow this is awesome, +1 to this

@erin-doyle
Copy link
Collaborator

All of the changes made in romeovs's fork have been merged and included in v1.0.0! 🎆 Please update to v1.0.0 to receive all these wonderful improvements!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants