Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use React.findDOMNode to log element references #54

Closed
kloots opened this issue Jun 9, 2015 · 3 comments
Closed

Use React.findDOMNode to log element references #54

kloots opened this issue Jun 9, 2015 · 3 comments
Assignees

Comments

@kloots
Copy link
Collaborator

kloots commented Jun 9, 2015

When there's an error, we currently use document.getElementById to log element element references. Since the code is executed in a componentDidMount/componentDidUpdate callback, we could use React.findDOMNode() instead.

@kloots kloots self-assigned this Jun 9, 2015
@alexlande
Copy link
Contributor

Between this and #55, would that mean that ID generation was no longer necessary?

If that was the case, I think it would indirectly resolve a few currently open issues: #77, #79, #85

I could take a shot at this if you'd like, @kloots.

@dmitrif
Copy link

dmitrif commented Mar 10, 2016

Hi, guys!

Has there been any changes in regards to this?

Thanks.

@erin-doyle
Copy link
Collaborator

I believe as of v1.0.0 we are no longer using document.getElementById for anything. I'm going to go ahead and close this but please let me know if you disagree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants