Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thoughts on react-a11y and ESLint #25

Closed
EvHaus opened this issue Apr 18, 2015 · 2 comments
Closed

Thoughts on react-a11y and ESLint #25

EvHaus opened this issue Apr 18, 2015 · 2 comments

Comments

@EvHaus
Copy link

EvHaus commented Apr 18, 2015

I wonder if react-a11y might be better served as an ESLint plugin (similar to https://www.npmjs.com/package/eslint-plugin-react)?

Currently, to use react-a11y you need to load it into your code (remembering to remove it for production builds), run your app, open the dev tools, review the warnings, go back to your code editor, make the fix, then reload the app again to confirm the warning went away. With ESLint, those warnings could be directly integrated into build tools, and code editors without having to actually execute the application code.

Any thoughts?

@kloots
Copy link
Collaborator

kloots commented May 13, 2015

Feels out of scope for this project. This isn't meant to be a static analysis tool.

@beefancohen
Copy link

@globexdesigns https://github.com/evcohen/eslint-plugin-jsx-a11y working on that right now, let me know if you'd like to help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants