Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential es5 goodies causing js errors in Android browser and IE8 #8

Closed
dougmcclurg opened this issue Feb 11, 2015 · 1 comment
Closed

Comments

@dougmcclurg
Copy link

Amazing project, love the work you are doing!

Just noticed if i require react-a11y before my es5 shims and shams i get JS errors on IE8 and older Android browsers.
Unfortunately neither of these devices/technologies allow me to get a valid error message that i can pass on to you guys. My minimal investigation tells me IE8 and android(internet) is not handling some es5 or 6 goodies.

Requiring the library after the es5 shim works fine.

@necolas
Copy link

necolas commented May 13, 2015

This isn't a bug, since React requires an es5 shim too: https://facebook.github.io/react/docs/working-with-the-browser.html#browser-support-and-polyfills

@kloots kloots closed this as completed May 21, 2015
erin-doyle pushed a commit that referenced this issue Nov 14, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants