Mark all failing tags with an ID and include it in the message #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is pretty darn helpful! |
Conflicts: lib/index.js
|
ping @ryanflorence |
|
This and all of my other PRs are available with |
kloots
added a commit
that referenced
this pull request
May 13, 2015
Mark all failing tags with an ID and include it in the message
Closed
erin-doyle
pushed a commit
that referenced
this pull request
Nov 14, 2017
Fixed #11 from being too strict testing for use-onblur-not-onchange. …
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR restructures assertAccessibility so that when an element fails it can add a unique
id(if one doesn't already exist) and logs it in the message.document.getElementById('a11y-0')will show me the element that is failing. Then withReveal in Elements Panel(Chrome's terminology) you can track down where it is.Closes #11
Closes #9
This is a better solution as it marks all of your elements so you can find them. No need to guess based on a stack or logging the props.