Skip to content
This repository has been archived by the owner on Jul 19, 2019. It is now read-only.

[added] wrapperProps and wrapperStyle props #50

Closed
wants to merge 1 commit into from

Conversation

zoeabryant
Copy link

Thank you for this contribution, it has been very useful in our project.
I have created this pull request because we needed more control over the rendering of the widget. Our project has a very strict design manual, so it is important that we are able to add classes and overwrite default styling.

@cdevienne
Copy link

I used your patch for our application. +1 for an upstream merge !

Thanks

@otmjka
Copy link

otmjka commented Jan 21, 2016

+1

@otmjka otmjka mentioned this pull request Jan 21, 2016
@docentq2
Copy link

+1

@525c1e21-bd67-4735-ac99-b4b0e5262290

+1 and a "thank you" to @zoeabryant. This is absolutely vital.

I've rebased this in 1f960f1

@joe-harter
Copy link

What is delaying the merge of this? Is there anything I can do to help speed it along?

@Neitsch
Copy link
Contributor

Neitsch commented Mar 7, 2016

+1
@ryanflorence @sprjr is this project still active?

@whichsteveyp
Copy link
Contributor

Moderately active. Ryan asked to review "API changes" but otherwise I'm trying to catch up on some of these PRs and get it moving again as one of our internal modules uses it too

I'm going to merge #77 tomorrow (huzzah, tests) and then try to get the other PR with recent comments merged as well. I can look at a few more later this week likely as well.

Sent from my iPhone

On Mar 6, 2016, at 8:07 PM, Nigel Schuster notifications@github.com wrote:

+1
@ryanflorence @sprjr is this project still active?


Reply to this email directly or view it on GitHub.

@orbiteleven
Copy link

@sprjr @zoeabryant Can we get this in?

@whichsteveyp
Copy link
Contributor

This will need rebased from the latest merge from master, and we should include tests that verify the wrapperProps and wrapperStyle make it in as intended. Other than that it looks good to me.

@laughnan
Copy link

what is the status of this PR?

@Neitsch
Copy link
Contributor

Neitsch commented May 2, 2016

Should be closed. Resolved by #91

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants