Fix tempalte literals handling

reactjs · Jan 8, 2024 · 64bf1aa · 64bf1aa
1 parent 6b6bdf7
commit 64bf1aa
Show file tree

Hide file tree

Showing 3 changed files with 15 additions and 1 deletion.
diff --git a/.changeset/slimy-donkeys-bow.md b/.changeset/slimy-donkeys-bow.md
@@ -0,0 +1,5 @@
+---
+"react-docgen": patch
+---
+
+Fix handling of template literals
diff --git a/packages/react-docgen/src/utils/__tests__/getMemberExpressionValuePath-test.ts b/packages/react-docgen/src/utils/__tests__/getMemberExpressionValuePath-test.ts
@@ -38,6 +38,15 @@ describe('getMemberExpressionValuePath', () => {
       );
     });
 
+    test('handles template literals', () => {
+      const def = parse.statement(`
+        var Foo = function Bar() {};
+        Foo[\`some\${template}\`] = () => {};
+      `);
+
+      expect(getMemberExpressionValuePath(def, 'something')).toBeNull();
+    });
+
     test('ignores computed property definitions with expression', () => {
       const def = parse.statement(`
         var Foo = function Bar() {};

diff --git a/packages/react-docgen/src/utils/getMemberExpressionValuePath.ts b/packages/react-docgen/src/utils/getMemberExpressionValuePath.ts
@@ -87,7 +87,7 @@ const explodedVisitors = visitors.explode<TraverseState>({
       const property = memberPath.get('property');
 
       if (
-        (!memberPath.node.computed || property.isLiteral()) &&
+        (!memberPath.node.computed || property.isStringLiteral() || property.isNumericLiteral()) &&
         getNameOrValue(property) === state.memberName &&
         toString(memberPath.get('object')) === state.localName
       ) {