Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly evaluate defaultValue and not only PropType. #45

Closed
oliviertassinari opened this issue Dec 11, 2015 · 3 comments
Closed

Correctly evaluate defaultValue and not only PropType. #45

oliviertassinari opened this issue Dec 11, 2015 · 3 comments

Comments

@oliviertassinari
Copy link

I have created a failing test to show you my issue: #46.
The defaultValue is not extracted correctly.
@oliviertassinari oliviertassinari mentioned this issue Dec 11, 2015
Merged
@donnieberg
Copy link

@oliviertassinari +1 on this bug with ES6.
MyComponent.defaultProps = { propName: "propVal" };

@fkling
Copy link
Member

fkling commented Jan 4, 2016

Fixed with 27c9ec2 and published with v2.5.0

@fkling fkling closed this as completed Jan 4, 2016
@oliviertassinari
Copy link
Author

Thanks.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@fkling @oliviertassinari @donnieberg