Update main-test.js #46
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test that the evaluation is working for the defaultProps and not only propTypes.
|
Given that the test fails, it seems that |
|
Exactly. |
|
@fkling Thanks for brining this to their attention. I'm using ES6 classes and am experiencing the same problem with getting defaultProps documentation from my components. |
|
I fixed the issue locally and simply changed the existing tests to use referenced propTypes and defaultProps, instead of adding your additional test. I hope that's fine with you, thank you very much for noticing this issue! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test that the evaluation is working for the defaultProps and not only propTypes.