For #6 Support ES6 export declarations

[morlay]

#6

import React from 'react';
export default React.createClass(...);
// or
export var Component = React.createClass(...);
// etc

This way is done.

Should we support this?

import React, { createClass } from 'react';
export default createClass(...);

And not sure, is it ok, to support ES6 module and CommonJS in one handler.

[facebook-github-bot]

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!

[facebook-github-bot]

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

[fkling]

Sweet! I will take a close look later today. Thank you for this!

[fkling]

Mmh, do we have to introduce resolveToCallExpression? My approach would have been to just extract the path from ExportDeclaration that we are interested in, and run resolveToValue on that.

Thoughts?

[morlay]

Sure, seems we can change here with

path = resolveToValue(path.get('declaration'));

and add the conditions to resolveToValue

if (types.VariableDeclaration.check(node)) {
    return resolveToValue(path.get('declarations', 0))
  } else if (types.VariableDeclarator.check(node)) {
     if (node.init) {
       return resolveToValue(path.get('init'));
     }
  } 

I will push another commit to update the change.

however, I feel the resolveToValue need to do some refact when we added a lot of conditions.

Thanks.

[fkling]

It doesn't seem like this would support support

export {
  comeponent,
  something else
};

or does it?

Should we support this?

import React, { createClass } from 'react';
export default createClass(...);

Not sure. I think if the need arises we can still that.

And not sure, is it ok, to support ES6 module and CommonJS in one handler.

Seems fine to me.

[morlay]

Cool. I feel we are not necessary to write like that.

With react-docgen's help, we can get docs so easy, in my last projects.

So I put the docs tool in my testing repo (preview)

Recently, we need to update to ES6, that why I try to make the update for react-docgen.

[fkling]

Sorry for the late response! I included your changes in 55c1511 and 9e8670c (I squashed the third one).

I also built on top of your changes and added support for the remaining import and export variations.

All these changes are release with v1.3.0.

Thanks for your help!