Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cannot find module 'jsdom' #31

Closed
basarat opened this issue Aug 7, 2015 · 3 comments
Closed

cannot find module 'jsdom' #31

basarat opened this issue Aug 7, 2015 · 3 comments
Assignees
Labels

Comments

@basarat
Copy link

basarat commented Aug 7, 2015

var jsdom = require('jsdom').jsdom;
But it doesn't actually have a dependency on it :
"jsdom-no-contextify": "~3.1.0"

Refs TypeStrong/atom-typescript#519 (comment)

@Daniel15
Copy link
Member

Daniel15 commented Aug 7, 2015

Sorry about that! I got a pull request to switch from jsdom to jsdom-no-contextify, but it looks like the require statement wasn't updated. Everything still worked when I was testing it, since I still had the old jsdom in my node_modules (I guess npm doesn't clean up unused modules). I'm still learning the ins and outs of npm 😄. I'll fix this right now.

@Daniel15 Daniel15 self-assigned this Aug 7, 2015
@Daniel15
Copy link
Member

Daniel15 commented Aug 7, 2015

Fixed in 0.2.4.

@Daniel15 Daniel15 closed this as completed Aug 7, 2015
@Daniel15 Daniel15 added the bug label Aug 7, 2015
@basarat
Copy link
Author

basarat commented Aug 7, 2015

No worries. I got all this code for free soooo 🌹 ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants