Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed link to HTML-to-JSX online transform #145

Merged
merged 1 commit into from Oct 6, 2017
Merged

Fixed link to HTML-to-JSX online transform #145

merged 1 commit into from Oct 6, 2017

Conversation

@bvaughn
Copy link
Contributor

@bvaughn bvaughn commented Oct 5, 2017

The README points to a specific page on the old React website that just redirects back to a specific page on the react-magic website- and with the launch of the new React website, the redirect page has been removed. So this PR updates the link to remove the needless redirect.

(The react-magic page is also broken but...that was the case beforehand too.)

@Daniel15
Copy link
Member

@Daniel15 Daniel15 commented Oct 5, 2017

@bvaughn
Copy link
Contributor Author

@bvaughn bvaughn commented Oct 5, 2017

Can we keep the redirect on the new React site

I'd prefer not to continue to accrue/support undocumented external dependencies like this to be honest. 😄 We can do it if you feel strongly about it. You're right in that it would be a simple matter of adding an entry to a static redirects file in the new React repo.

@juliettepretot
Copy link

@juliettepretot juliettepretot commented Oct 6, 2017

Alternatively you can copy the files formerly on facebooks GitHub repo into this repo. I've done this in my fork of HTMLtoJSX

@Daniel15 Daniel15 merged commit 11c2aac into master Oct 6, 2017
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@Daniel15 Daniel15 deleted the fix-link branch Oct 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants