Fixed link to HTML-to-JSX online transform #145
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we keep the redirect on the new React site, just in case people have
bookmarked the old version? Netlify makes it easy to add permanent
redirects.
In any case, this sounds reasonable to me.
Sent from my phone.
…On Oct 6, 2017 8:46 AM, "Brian Vaughn" ***@***.***> wrote:
The README
<https://github.com/reactjs/react-magic/blob/master/README-htmltojsx.md>
points to a specific page on the old React website
<https://github.com/facebook/react/blob/master/docs/html-jsx.html> that
just redirects back to a specific page on the react-magic website
<http://magic.reactjs.net/htmltojsx.htm>- and with the launch of the new
React website, the redirect page has been removed. So this PR updates the
link to remove the needless redirect.
------------------------------
You can view, comment on, or merge this pull request online at:
#145
Commit Summary
- Fixed link to HTML-to-JSX online transform
File Changes
- *M* README-htmltojsx.md
<https://github.com/reactjs/react-magic/pull/145/files#diff-0> (2)
Patch Links:
- https://github.com/reactjs/react-magic/pull/145.patch
- https://github.com/reactjs/react-magic/pull/145.diff
—
You are receiving this because you were assigned.
Reply to this email directly, view it on GitHub
<#145>, or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAFnHSxQHyGWVVP0AMxoh1FZ0ou5z_jpks5spU5IgaJpZM4PvvtA>
.
|
I'd prefer not to continue to accrue/support undocumented external dependencies like this to be honest. 😄 We can do it if you feel strongly about it. You're right in that it would be a simple matter of adding an entry to a static redirects file in the new React repo. |
|
Alternatively you can copy the files formerly on facebooks GitHub repo into this repo. I've done this in my fork of HTMLtoJSX |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README points to a specific page on the old React website that just redirects back to a specific page on the react-magic website- and with the launch of the new React website, the redirect page has been removed. So this PR updates the link to remove the needless redirect.
(The react-magic page is also broken but...that was the case beforehand too.)