sanitizeProps causes error

[suprsidr]

Summary:

Uncaught TypeError: Cannot delete property 'ref' of #<Object>

Steps to reproduce:

1. open modal
2. Uncaught TypeError: Cannot delete property 'ref' of #<Object>
   Modal.js line 78 sanitizeProps(props) -> line 115 delete props.ref;

Additional notes:

if I comment out the call to sanitizeProps all is good.

just upgraded to react 15.0.1 and react-dom 15.0.1
Worked fine prior

[diasbruno]

@suprsidr awesome! i'll check it.

[rmertens]

Getting the same error (also react 15.0.1)!

[diasbruno]

@suprsidr @rmertens can you make a simple example were you can reproduce it?

[rmertens]

@diasbruno uploaded here: https://github.com/rmertens/react-modal-bug-example

[wikiwong]

No mean to clutter, but I am getting the same error as well. Feel free to tag me for any additional info I can provide.

Thanks for looking into this guys!

[diasbruno]

If sanitizeProps(props) is moved to Modal::componentWillReceiveProps(), it works fine.

react: 15.0.1, react-dom: 15.0.1, react-modal: 1.1.1

Is there a reason to sanitizeProps() is called in Modal::renderPortal()? @claydiffrient

Some info from react docs:

Never access refs inside of any component's render method – or while any component's render method is even running anywhere in the call stack.

react/docs - Ref to Components

[diasbruno]

Also tested with react: 15.0.0, react-dom: 15.0.0, react-modal: 1.1.1 and works fine.

[claydiffrient]

Fix released as v1.1.2