Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shift + Tab immediately after the modal opens causes focus to be lost. #23

Closed
claydiffrient opened this issue Mar 18, 2015 · 0 comments
Closed

Shift + Tab immediately after the modal opens causes focus to be lost. #23

claydiffrient opened this issue Mar 18, 2015 · 0 comments

Comments

@claydiffrient
Copy link
Contributor

Pressing Shift+Tab takes focus outside of the modal and underneath the overlay.

As far as I can tell this is because of https://github.com/rackt/react-modal/blob/master/lib/components/ModalPortal.js#L83 which focuses on the ReactModal__Content div which is great.

The problem is that the tab isn't scoped at that point by https://github.com/rackt/react-modal/blob/master/lib/helpers/focusManager.js so until the end user drills into the modal the tab isn't scoped around the elements inside allowing them to go back with Shift+Tab and escape the modal's grasp.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@claydiffrient