Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacement for HTMLElement in code? #34

Closed
AndrewRayCode opened this issue May 5, 2015 · 1 comment
Closed

Replacement for HTMLElement in code? #34

AndrewRayCode opened this issue May 5, 2015 · 1 comment

Comments

@AndrewRayCode
Copy link
Contributor

This library uses the global HTMLElement which only exists in DOM land. We mock our environment with JSDom, however this code is loaded at require() time before JSDom is instantiated, so the require fails and crashes execution. What about React.PropTypes.object, or global.HTMLElement (which wouldn't fail the require() and also fix the linting error in the file) or typeof window === "undefined" ? React.PropTypes.object : global.HTMLElement ?
@mzabriskie
Copy link
Member

Resolved with #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@AndrewRayCode @mzabriskie