Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix BrowserStack config #3678

Merged
merged 1 commit into from Jul 29, 2016
Merged

Fix BrowserStack config #3678

merged 1 commit into from Jul 29, 2016

Conversation

taion
Copy link
Contributor

@taion taion commented Jul 28, 2016

@taion
Copy link
Contributor Author

taion commented Jul 28, 2016

Bleh, I might just disable BrowserStack for now until @mjackson can tell me how to do this correctly 😄

We're not directly accessing browser APIs anyway except via history, so it's sort of "good enough" that we have coverage via history.

@taion
Copy link
Contributor Author

taion commented Jul 28, 2016

Huh, Coveralls decided that it should do something now. Weird.

@timdorr
Copy link
Member

timdorr commented Jul 28, 2016

That's because you're running the tests locally, so it can collect the stats coveralls uses now.

We've got one brower API use now, but not significant enough to test this across a handful of browsers and have to maintain the versions of those browsers used in the suite. I'd say nuke them and rely on the basic browser versions on Travis.

@taion
Copy link
Contributor Author

taion commented Jul 28, 2016

Gah it's busted on history too: https://travis-ci.org/ReactTraining/history/builds/144879254

The last commit sets us up to run on Firefox and Chrome on Travis. Seems okay.

Congrats BTW (:

@mjackson
Copy link
Member

I've emailed BrowserStack to see if we can figure out what's going on. I'd rather keep the tests running on BrowserStack, but it has been pretty flaky lately...

@mjackson
Copy link
Member

BrowserStack has renewed my subscription. They sponsor us, and the sponsorship had expired. I'm going to follow up w them so this hopefully doesn't happen again in a few years.

@taion
Copy link
Contributor Author

taion commented Jul 29, 2016

Cool... I also got the Codecov status thing fixed. Their patch status is a neat surface-level check to filter out new code that doesn't have adequate test coverage. Might turn off Coveralls entirely.

Gonna merge since this is just a tooling chore to align with history.

@taion taion merged commit 4fd1db5 into master Jul 29, 2016
@taion taion deleted the fix-browserstack branch July 29, 2016 17:56
@lock lock bot locked as resolved and limited conversation to collaborators Jan 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants