Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tab is Not Focussed on First Click #272

Closed
thejamespower opened this issue Dec 3, 2018 · 6 comments · Fixed by #349
Closed

Tab is Not Focussed on First Click #272

thejamespower opened this issue Dec 3, 2018 · 6 comments · Fixed by #349
Labels

Comments

@thejamespower
Copy link

When clicking on a tab, it is expected that focus would be placed on that tab to instantly enable keyboard navigation. Currently this does not occur until the second click, or by pressing tab.

It is also worth noting that WAI-ARIA recommends handling roving tabindex like this: https://www.w3.org/TR/wai-aria-practices/#kbd_roving_tabindex

@flurmbo
Copy link

flurmbo commented Oct 3, 2019

Hi, does anyone mind if I work on this issue?

@joepvl
Copy link
Collaborator

joepvl commented Oct 4, 2019

I'd say go for it! It's probably a good idea to detail what the current behaviour is (since the issue is from almost a year ago — although I don't think the behaviour has changed in the mean time) and how you'd like to change it.

@Morta1
Copy link
Contributor

Morta1 commented Dec 9, 2019

hey @flurmbo, any update about this issue?
I still need to click twice on the tab header to be able to navigate with the keyboard.

@arur
Copy link

arur commented Feb 27, 2020

This is still relevant. I guess there are no updates on this one.

@bestuiexperience
Copy link

I am also wondering if there will be a fix for this. I think this was working properly in an earlier version of React tabs. It is considered an accessibility violation not to display a focus ring around the active tab.

danez pushed a commit that referenced this issue Mar 1, 2022
BREAKING CHANGE: The tabs are now instantly focused on click. The default styling has been adapted for that, so that there is no outline shown anymore on focus.

closes #272
@danez danez closed this as completed in 4512dad Mar 1, 2022
@github-actions
Copy link

github-actions bot commented Mar 1, 2022

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants