Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation about which style numeric values are treated as pixels is missing #27

Closed
bvaughn opened this issue Oct 6, 2017 · 2 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

This change was originally requested by @Kovensky via facebook/react/issues/10418

This used to exist in the React 15 documentation under the Tips section, but mentions to this support are now missing entirely.

The old documentation page: https://github.com/facebook/react/blob/8cac523beaaacfeae179ca14a1d8a46d82892016/docs/tips/06-style-props-value-px.md

This was removed in commit 455d2d1b48e5cdaeac5d0b4fd92b29b4d52bcaec

@fanny
Copy link

fanny commented Oct 6, 2017

basically it is necessary to add the information of the pixels to this page? https://reactjs.org/docs/dom-elements.html#style

@Jessidhia
Copy link

An important thing that new documentation needs to mention is that, as of React 16, this only applies to actual number values. Numeric strings used to work (with a warning in React 15), but now they are always passed as-is.

jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* docs: Translate Web Components page

* Update content/docs/web-components.md

Co-Authored-By: thealexandrelara <thealexandrelara@gmail.com>

* Update content/docs/web-components.md

Co-Authored-By: thealexandrelara <thealexandrelara@gmail.com>
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* Fix links in lists-and-keys page reactjs#7

* Fix links in faq-ajax page reactjs#9

* Fix links in faq-build page reactjs#12

* Fix links in web-components page reactjs#27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants