-
Notifications
You must be signed in to change notification settings - Fork 7.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New guides wanted #83
Comments
The ReactPerf item may sorta be OBE ("overtaken by events"), since it's not included in v16. |
Not sure what that acronym means but I assume you're suggesting we should remove it? 😄 I don't object. |
Not sure if you're already planning it, but I would add Didn't bind class methods to common troubleshooting issues 👍 |
@bvaughn : yeah, that's what I was suggesting :) @JasonEtco : the "troubleshooting" suggestion overlaps heavily with the proposal for an FAQ page. |
@bvaughn Accessibility has been added and can be checked off :-) |
I'll take the glossary that I created in the old repo and migrate it to the new docs repo |
As @markerikson mentioned there is some overlap with the FAQ discussion (#29). PR #43 covers AJAX and some of the VDOM concepts although a full-fledged glossary would probably replace that section. |
Thanks @AlmeroSteyn. I've removed that entry. Yeah, there's some overlap. I spent a few hours merging/moving issues and PRs yesterday but some of the larger/vaguer ones like this are a bit hard to do without a bit of overlap. I'll add a note in the description about the relationship. |
Hey @bvaughn , I would like to work on "AJAX (just show how to use |
It's all yours, @ishankbahl |
@ishankbahl @bvaughn AJAX is already in the FAQ PR #43, as I pointed out. If that is too big of a PR to review I can break it up, but let's not duplicate effort. |
Sorry for missing that note, @alexkrolick. Thanks for pointing it out. Yeah, maybe hold off on doing anything with the AJAX section until after #43 has been reviewed @ishankbahl. |
I just created a pull request for the glossary content: #153 |
I'll take a stab at creating a guide for publishing a component if no one is currently working on it? |
Ok @mateoholman |
@bvaughn Can I take snapshot testing? |
Sure @ishankbahl |
@bvaughn What outline do you suggest for this guide? |
No clue 😄 Haven't thought about it any. Just migrated this issue from the old GitHub repo. |
Created a new PR for the "Publishing a Component" guide - #211. |
I'll try to tackle the community section per the recommendations in facebook/react#7117 next if no one is currently working on it? |
It's yours, @mateoholman |
After doing some prep/research, I see two approaches to the community section. Adding a new Resources section to the docs page similar to the React Native Docs or updating the React Wiki. Both have been suggested in previous issues - any preference @bvaughn ? |
👋 Hi @mateoholman. Sorry for the slow response time but I've been traveling. I'm personally more a fan of the community page/section because it's more open for community contributions. |
👋 Hi @bvaughn . No worries, I had been scrubbing some of the outdated / broken links from the previous section. I should have a PR ready for review in a few days. 🍻 |
Sure @mateoholman. It's yours. |
@bvaughn I'd like to take the Troubleshooting Guide: Besides the following you listed (like wrong element casing, not loaded DOM container, missing React in scope) any other items you suggest being covered? |
Okay @chiangs, please feel free to work on that! :) |
* First try * Translated Thinking in React * Delete package-lock.json * Update content/docs/thinking-in-react.md Review feedback Co-Authored-By: rafaelquintanilha <rafaelquintanilha@poli.ufrj.br> * Review feedback * Review feedback * Update content/docs/thinking-in-react.md Co-Authored-By: rafaelquintanilha <rafaelquintanilha@poli.ufrj.br>
It looks like portals have been taken care of right? |
Is this issue open? Can you assign it to me if it is? |
@bvaughn Is anyone taking animation with react motion? I would like to give it a go. |
Note this issue has some overlap with FAQ section issue #29.
We revamped the docs, but there are a few guides that are missing and that I think are essential.
Available
cloneElement
andChildren
React.cloneElement docs are a bit light facebook/react#6942)setState
with HTML5 history API and point to RR as a component-based API for it once v4 is out)react-test-renderer
facebook/react#7431)In progress
fetch()
in lifecycles, mention cancellation issues)If somebody wants to work on this please comment here and let's figure out a plan. Help wanted!
Carry over from facebook/react/issues/8060
The text was updated successfully, but these errors were encountered: