Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error boundaries and exception tracking to the website #9

Open
bvaughn opened this issue Oct 6, 2017 · 8 comments
Open

Add error boundaries and exception tracking to the website #9

bvaughn opened this issue Oct 6, 2017 · 8 comments

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

Part 1: Gracefully handle exceptions

If an error occurs, we should show some kind of fallback UI.

We already handle specific types of errors like failing to load Babel or Algolia libs from CDN, but a more general-purpose error boundary would be nice to handle other unexpected errors.

Part 2: Track exceptions

We should also log/track errors as well. Maybe we could use GA's exception tracking for this?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 6, 2017

This issue can also potentially help with #14

@ishankbahl
Copy link
Contributor

Hey @bvaughn , wanted to work on this. Looks like issue #3 , #14 , facebook/react#11008 can be solved by applying error boundaries around CodEditor, Header and Layout component where we just nudge people to whitelist the site in adblockers (As these are happening due to Fair Adblocker) . What are your thoughts?

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 8, 2017

Agreed that error boundaries could probably help with a couple of issues! Please feel free to take this! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 18, 2017

It looks like the remaining TODO here (the search box) isn't being actively worked on so I'm removing the in-progress label.

bvaughn added a commit that referenced this issue Oct 20, 2017
Disable Search Box if CDN is down (#9)
@SadPandaBear
Copy link
Contributor

SadPandaBear commented Oct 20, 2017

Hey @bvaughn I think #186 is closing this now.

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 20, 2017

We've added specific error-handling for failed docsearch and Babel loads, but this issue still remains open to add at least one general purpose error boundary around the site in case of other, unexpected errors.

@bvaughn bvaughn changed the title Add error boundaries to the website Add error boundaries and exception tracking to the website Nov 17, 2017
gaearon added a commit to gaearon/reactjs.org that referenced this issue Feb 9, 2019
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
* Fix links in lists-and-keys page reactjs#7

* Fix links in faq-ajax page reactjs#9

* Fix links in faq-build page reactjs#12

* Fix links in web-components page reactjs#27
@naveen1249
Copy link

..

@spiritanand
Copy link

Is this issue open? Can you assign it to me if it is?

BetterZxx pushed a commit to BetterZxx/react.dev that referenced this issue Mar 21, 2023
* docs(cn): translate content/docs/hello-world.md into Chinese

* fix(cn): translate is wrong

* fix: fix translation errors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants