Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing Docs #2165

Merged
merged 9 commits into from Aug 8, 2019
Merged

Testing Docs #2165

merged 9 commits into from Aug 8, 2019

Conversation

threepointone
Copy link
Contributor

@threepointone threepointone commented Jul 23, 2019

This expands the testing docs for reactjs.org. It adds 3 main docs -

  • testing.md: An entry point to the testing docs
  • testing-recipes.md: Common patterns when writing tests for React Components.
  • testing-environments.md: Setting up your testing environment.

https://deploy-preview-2165--reactjs.netlify.com/docs/testing.html
https://deploy-preview-2165--reactjs.netlify.com/docs/testing-recipes.html
https://deploy-preview-2165--reactjs.netlify.com/docs/testing-environments.html

@reactjs-bot
Copy link

reactjs-bot commented Jul 23, 2019

Deploy preview for reactjs ready!

Built with commit 16e166d

https://deploy-preview-2165--reactjs.netlify.com

@gaearon
Copy link
Member

gaearon commented Jul 23, 2019

Can you add them temporarily to sidebar somewhere so that it’s easy to preview what you already posted on a live site?

@threepointone
Copy link
Contributor Author

It's now under Advanced Guides > Testing

This expands the testing docs for reactjs.org. It adds 4 main docs -

- testing.md: An entry point to the testing docs
- testing-recipes.md: Common patterns when writing tests for React Components.
- testing-environments.md: Setting up your testing environment.
- act.md: Notes on React's act() test helper.

Once this is in place, we'll decide whether to add links to the sidebar, and further steps.
content/docs/act.md Outdated Show resolved Hide resolved
content/docs/act.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Show resolved Hide resolved
content/docs/testing-recipes.md Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Outdated Show resolved Hide resolved
Thanks @alexkrolick!

Co-Authored-By: Alex Krolick <alexkrolick@users.noreply.github.com>
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

High level feedback: we need to use less jargon and be more concrete.

content/docs/testing-environments.md Outdated Show resolved Hide resolved
content/docs/testing-environments.md Show resolved Hide resolved
content/docs/nav.yml Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Show resolved Hide resolved
content/docs/act.md Outdated Show resolved Hide resolved
content/docs/act.md Outdated Show resolved Hide resolved
content/docs/act.md Outdated Show resolved Hide resolved
content/docs/act.md Outdated Show resolved Hide resolved
content/docs/testing-recipes.md Outdated Show resolved Hide resolved
content/docs/act.md Outdated Show resolved Hide resolved
@threepointone threepointone force-pushed the testing-docs branch 10 times, most recently from c4517ca to b61cff5 Compare August 8, 2019 16:51
@threepointone threepointone changed the title [WIP / DO NOT MERGE] Testing Docs Testing Docs Aug 8, 2019
@gaearon gaearon mentioned this pull request Aug 8, 2019
9 tasks
Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I did a small edit pass. Let's tweak examples as we discussed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants