Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Fix wrong workflow file name #4192

Merged
merged 1 commit into from
Dec 21, 2021
Merged

Conversation

smikitky
Copy link
Member

@smikitky smikitky commented Dec 20, 2021

(This may be broken because I have no means to test this locally)

I believe the current CI setup for the beta site is broken because the workflow file refers to an old file name when it tries to download bundle_analysis.json from its base branch (normally main). This PR fixes this.

The base file currently used by the CI comes from the same old artifact (RunID: 1429732265, Artifact: 111304536) that happens to exist only in the main repository.

image

Currently, all CI runs are failing on translation forks because there is no previous run associated with bundle_analysis_upload.yml. I suspect the same problem will surface soon also in the main repository when the avobe-mentioned artifact expires after 90 days.

CC @gaearon

@github-actions
Copy link

Size Changes

📦 Next.js Bundle Analysis

This analysis was generated by the next.js bundle analysis action 🤖

This PR introduced no changes to the javascript bundle 🙌

@smikitky
Copy link
Member Author

Okay, I confirmed the CI for this PR uses a different artifact, so it seems to be working fine.

image

@harish-sethuraman
Copy link
Collaborator

The base file currently used by the CI comes from the same old artifact (RunID: 1429732265, Artifact: 111304536) that happens to exist only in the main repository.

Good find - Also I found that the artifact seems to be present in that run ID with this API (https://api.github.com/repos/reactjs/reactjs.org/actions/runs/1429732265/artifacts)

I guess it tries to take the latest artifact with that name which was created on 6.11.2021.

I suspect the same problem will surface soon also in the main repository when the avobe-mentioned artifact expires after 90 days.

This would not have happened since the workflow will expire on 2022-02-04T18:52:20Z

Workflow in this PR shows runId 1596411952
(https://api.github.com/repos/reactjs/reactjs.org/actions/runs/1596411952/artifacts)
and the created_at is 2021-12-18T16:44:04Z.
This was the last PR merge to main branch I guess. So now it pulls the latest artifact.

@harish-sethuraman harish-sethuraman merged commit d216582 into reactjs:main Dec 21, 2021
@harish-sethuraman
Copy link
Collaborator

Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants