Generate Ids when there are none in local development #4304
Conversation
harish-sethuraman
changed the title
Size Changes📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 Four Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this. |
| */ | ||
| if (match) { | ||
| if (!tail || tail.type !== 'text' || tail.value !== '/}') { | ||
| return; |
There was a problem hiding this comment.
These early exits didn't seem right. We want to assign ID from a slug regardless of whether we succeeded to modify the tail.
| const match = /^.+(\s*\{.*\}\s*)$/u.exec(rawHeader); | ||
| /** | ||
| * we check if there is a heading and custom id with regex. | ||
| * If there is a match then we set the id to be the match[1] which is the custom id |
There was a problem hiding this comment.
These comments are repeating the code. It's better if we use the comments for things that aren't clear from the code (like why does the code do things we want it to do rather than what it does).
| let tail = children[children.length - 1]; | ||
|
|
||
| // A bit weird: this is to support MDX 2 comments in expressions, |
There was a problem hiding this comment.
This was a valuable comment so we shouldn't nix it.
| } | ||
|
|
||
| tail = children[children.length - 2]; | ||
|
|
||
| if (!tail && tail.type !== 'emphasis') { |
There was a problem hiding this comment.
This was a mistake in the original code btw. It should've used || because otherwise the second check would crash whenever tail is null or undefined.
(reactjs#721) * Sandpack error icon overlapping issue fix (reactjs#4302) * sandpack error icon overlapping issue fix * modified errorline css * Improve font display (reactjs#4308) * Generate Ids when there are none in local development (reactjs#4304) * Generate Ids when there are no headings * Tweak code Co-authored-by: Dan Abramov <dan.abramov@gmail.com> * [Beta] useState Troubleshooting (reactjs#4309) * [Beta] useState Troubleshooting * Tweaks * tweak * docs: phrasing a sentence (reactjs#4185) * docs: phrasing a sentence (reactjs#4182) * docs: phrasing a sentence * Update extracting-state-logic-into-a-reducer.md Co-authored-by: dan <dan.abramov@gmail.com> * docs: fix a grammatical error (reactjs#4183) Co-authored-by: dan <dan.abramov@gmail.com> * Change "return statement" to "return keyword" (reactjs#4137) * small fixes to stopwatch codesandbox (reactjs#4110) * small fixes to stopwatch codesandbox noticed that the explanation for the first stopwatch codesandbox mentions "update the time every 10 milliseconds" so updated the codesandbox to reflect that also there's a small nuanced bug in the second stopwatch codesandbox where each call to `handleStart()` sets a new interval without checking if there's already one ongoing. Ie: If the user accidentally double clicks the start button, they set two intervals for updating `now` every 10ms and then intervalRef only retains the second interval ID. Thus, it's impossible to actually stop the timer because `handleStop()` will only clear the latest set interval while the original one will keep executing. * Update referencing-values-with-refs.md * Update referencing-values-with-refs.md * Update referencing-values-with-refs.md Co-authored-by: dan <dan.abramov@gmail.com> * Resolve conflicts Co-authored-by: Amaresh S M <amaresh.suriya@freshworks.com> Co-authored-by: Sha Mwe La <62544170+shamwela@users.noreply.github.com> Co-authored-by: Strek <harish.sethuraman@freshworks.com> Co-authored-by: Dan Abramov <dan.abramov@gmail.com> Co-authored-by: Sofya Tuymedova <stuymedova@gmail.com> Co-authored-by: Soichiro Miki <smiki-tky@umin.ac.jp> Co-authored-by: Aayush Kumar <aayush.kumarmail@gmail.com> Co-authored-by: KnowsCount <knowscount@gmail.com>
Seems like we weren't generating new ids at runtime so while developing in local it was generating link as undefined?
So added code to generate fallback ids when there are none.