Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update @codesandbox/sandpack-react version to 2.13.4 #6664

Merged
merged 4 commits into from Feb 27, 2024

Conversation

danilowoz
Copy link
Contributor

Fixes #6662

Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
react-dev ✅ Ready (Inspect) Visit Preview Feb 27, 2024 5:13pm

Copy link

github-actions bot commented Feb 27, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

⚠️ Global Bundle Size Increased

Page Size (compressed)
global 103.9 KB (🟡 +42 B)
Details

The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!

@danilowoz danilowoz marked this pull request as ready for review February 27, 2024 15:34
@danilowoz
Copy link
Contributor Author

@harish-sethuraman, it should be fixed now. Could you please review it?

@danilowoz danilowoz changed the title fix: Update @codesandbox/sandpack-react version to 2.13.3 fix: Update @codesandbox/sandpack-react version to 2.13.4 Feb 27, 2024
@harish-sethuraman
Copy link
Collaborator

Changes are working fine. Checked the following

  • Loading of previews in multiple (random) pages
  • loading of sandpacks
  • errors and warnings

noticed once or twice the sandpack would load infinitely for unlimited time
Screenshot 2024-02-27 at 9 11 54 PM

small bug where open codesandbox text is not shown properly (exists in main too)
Screenshot 2024-02-27 at 9 15 19 PM

@danilowoz
Copy link
Contributor Author

It's very unusual that the sandbox didn't load. Once the static and dependencies are cached, everything should be instantly, but let's watch it. Just pushed one CSS fix for the "open codesandbox" thing. I think nobody has noted that so far because the bundler is fast enough to make the loading component obsolete, but for some reason, it failed for you.

@harish-sethuraman
Copy link
Collaborator

I think its fine. We can look into the issue if it pops up again. I was not able to reproduce the same error.

@harish-sethuraman harish-sethuraman merged commit 6d8e094 into reactjs:main Feb 27, 2024
4 checks passed
@danilowoz danilowoz deleted the fix/update-sandpack branch February 27, 2024 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Issue with Sandpacks
3 participants