Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Typo] Correct reference to sandboxed file App.js in challenge #7010

Merged

Conversation

ichistmeinname
Copy link
Contributor

The default name for sandboxed files seems to be App.js, but is wrongly referenced as Counter.js in one of the challenges. I decided to fix the reference in the text rather renaming the sandbox file due to (a) consistency with all other sandbox examples and (b) consistency with the corresponding solution that already mentions App.js.

Copy link

vercel bot commented Jul 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 3, 2024 7:03pm
react-dev ✅ Ready (Inspect) Visit Preview Jul 3, 2024 7:03pm

@facebook-github-bot
Copy link
Collaborator

Hi @ichistmeinname!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

Copy link

github-actions bot commented Jul 3, 2024

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@ichistmeinname ichistmeinname changed the title fix: Correct reference to sandboxed file App.js in challenge [Typo]]: Correct reference to sandboxed file App.js in challenge Jul 3, 2024
@ichistmeinname ichistmeinname changed the title [Typo]]: Correct reference to sandboxed file App.js in challenge [Typo] Correct reference to sandboxed file App.js in challenge Jul 3, 2024
@harish-sethuraman harish-sethuraman merged commit 1a3a3ef into reactjs:main Jul 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants