Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add minimum required Node version to create-react-app docs #70 #89

Merged
merged 1 commit into from Oct 9, 2017
Merged

Add minimum required Node version to create-react-app docs #70 #89

merged 1 commit into from Oct 9, 2017

Conversation

dance2die
Copy link
Contributor

Hi, addressing the issue #70
Add minimum required Node version to create-react-app docs #70

The line highlighted yellow is the change made.

image

@reactjs-bot
Copy link

Deploy preview ready!

Built with commit ca06794

https://deploy-preview-89--reactjs.netlify.com

@facebook-github-bot
Copy link
Collaborator

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need the corporate CLA signed.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Collaborator

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks!

Copy link
Contributor

@bvaughn bvaughn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is reasonable, since the latest/supported version of the tools require 6+.

@bvaughn bvaughn merged commit 695e790 into reactjs:master Oct 9, 2017
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this pull request Jul 1, 2020
* Translate LayoutHeader Component

* docs: Translate comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants