Create script for checks (prettier, lint, flow) in CI #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jxom
changed the title
|
Deploy preview ready! Built with commit 5a96b1d |
|
Some thoughts! 😄
|
|
@bvaughn - yeah was a bit unsure about what to name it! I was wondering why the linter didn’t pick up stuff like that too! Thought there may have been some reason why you configured it that way. 😆 Will check it out later on! |
|
Nope. I was trying for a minimal linter config and didn't test it thoroughly enough at the time. |
bvaughn
approved these changes
Oct 9, 2017
There was a problem hiding this comment.
This looks great! Catches a lot of small lint errors that have slipped through too 😄
Looks like we may have to do something special for certain Flow types, eg:
/Users/bvaughn/Documents/git/reactjs.org/src/theme.js
48:13 error '$Keys' is not defined no-undefBut we can iterate on things like this and not hook the new Yarn task into CI until they've all been fixed.
3 tasks
jhonmike
pushed a commit
to jhonmike/reactjs.org
that referenced
this pull request
Jul 1, 2020
BetterZxx
pushed a commit
to BetterZxx/react.dev
that referenced
this pull request
Mar 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This intends to fix #67.
check-all:verbosescript, which is similar tocheck-all, however lists errors out on prettier if the files are different from the prettier formatting.prettier:diffscript, which checks for a difference between the prettified files, and source files.Yay or nay?