Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial navigation highlight should update as you scroll #21

Closed
bvaughn opened this issue Oct 6, 2017 · 2 comments · Fixed by #48
Closed

Tutorial navigation highlight should update as you scroll #21

bvaughn opened this issue Oct 6, 2017 · 2 comments · Fixed by #48

Comments

@bvaughn
Copy link
Contributor

bvaughn commented Oct 6, 2017

When you click on side-nav items, the page scrolls to that section (with 4px blue span in front of the link text). If you scroll manually to those parts, the side-nav doesn't update to show where you're at.

You can see it on a screenshot, An Interactive Component should be active.

Originally reported by @vicodinchik via facebook/react/issues/10984

@jxom
Copy link
Contributor

jxom commented Oct 7, 2017

Hey @bvaughn! Can I tackle this one? :)

@bvaughn
Copy link
Contributor Author

bvaughn commented Oct 7, 2017

This issue is all yours! 😄

I've added an "in-progress" label so that others will know not to start work on the issue. If you change your mind about the issue, no worries! Just let me know so that I can remove the label and free it up for someone else to claim.

Cheers!

gaearon pushed a commit to gaearon/reactjs.org that referenced this issue Feb 9, 2019
Терминология: UI, интерфейс, рендер-пропсы + рефы (мн.), проп (ед.)
jhonmike pushed a commit to jhonmike/reactjs.org that referenced this issue Jul 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants