Fix scrolling to anchor with fixed menu #1855
Conversation
|
Deploy preview for reactjs ready! Built with commit a0a37d2 |
|
Hmmm: yarn run v1.10.1 |
|
Why anyone don't care on UI\UX fix? :) |
|
@alexkrolick please review this. |
|
@alexkrolick pls help us :) |
|
@EPolovniy you can remove unnecessary changes (in content files, |
|
Please revert changes that are not related to this PR. |
| toPath: version.url, | ||
| })), | ||
| versions | ||
| .filter(version => version.path && version.url) |
There was a problem hiding this comment.
Is this automatically done? Just change the code style, but why?
There was a problem hiding this comment.
This part changes for split function in chain to new line. I think the code looks better now.
| @@ -35,33 +32,43 @@ module.exports = ( | |||
| lastNode.value = lastNode.value.replace(match[1], ''); | |||
| } | |||
|
|
|||
| const data = patch(node, 'data', {}); | |||
There was a problem hiding this comment.
I'm not sure about changing this. Can we get back the old logic?
There was a problem hiding this comment.
This code not necessary and not work :)
There was a problem hiding this comment.
Let's just leave these things as they used to be, as well as that new line 🆙. I just want to have changes that solve the current problem.
*.md files and yarn.lock are marked as modified because you created your PR from the master branch. Let's fix this too.
There was a problem hiding this comment.
Ok, I will prepare a new Pull Request
|
@EPolovniy please look this PR #1914 |
| @@ -35,33 +32,43 @@ module.exports = ( | |||
| lastNode.value = lastNode.value.replace(match[1], ''); | |||
| } | |||
|
|
|||
| const data = patch(node, 'data', {}); | |||
There was a problem hiding this comment.
This code not necessary and not work :)
| toPath: version.url, | ||
| })), | ||
| versions | ||
| .filter(version => version.path && version.url) |
There was a problem hiding this comment.
This part changes for split function in chain to new line. I think the code looks better now.
|
*.md files and yarn.lock build automatically |
|
Add new request #1944 |
|
Closing in favor of #1944 |
We have bug with scrolling by anchor in headers:
I propose some fix: