Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate "State and Lifecycle" (state-and-lifecycle.md) #42

Merged
merged 10 commits into from
Feb 12, 2019

Conversation

agoldis
Copy link
Contributor

@agoldis agoldis commented Feb 9, 2019

Спасибо @lex111 за https://github.com/js-ru/react-ru/blob/master/content/docs/state-and-lifecycle.md - я использовал перевод как базу и референс, но изменил стилистику и переписал некоторые фразы, руководствуясь https://github.com/reactjs/ru.reactjs.org/blob/master/TRANSLATION.md

@agoldis agoldis mentioned this pull request Feb 9, 2019
88 tasks
@lex111 lex111 requested a review from gaearon February 9, 2019 23:48
@lex111 lex111 added the needs review A pull request ready to be reviewed label Feb 9, 2019
@agoldis agoldis changed the title Add "State and Lifecycle" russian translation Translate "State and Lifecycle" (state-and-lifecycle.md) Feb 9, 2019
Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Спасибо! Начал смотреть перевод, но при беглом осмотре увидел много отклонений от руководства по переводу, пожалуйста, ознакомтесь с ним, и скорректируйте перевод, позже будет легче снова делать ревью перевода.

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@lex111 lex111 added work in progress Author opened the pull-request but it's still being worked on and removed needs review A pull request ready to be reviewed labels Feb 10, 2019
@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

увидел много отклонений

@lex111 спасибо, я раньше не переводил. Насколько мешает (довольно) вольная интерпретация перевода? Например, я иногда менял местами части предложения чтобы оживить и точнее передать смысл - это допустимо? Или вы имеете в виду только употребление терминов?

@lex111
Copy link
Member

lex111 commented Feb 10, 2019

Или вы имеете в виду только употребление терминов?

Это в основном, да.

@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

@lex111 вроде исправил dfdb2df

@lex111
Copy link
Member

lex111 commented Feb 10, 2019

@agoldis там ещё проблемы со знаками пунктации, в принципе это легко поправить (заменить дефисы на тире).

@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

@lex111 заменил 5956570

@lex111 lex111 added needs review A pull request ready to be reviewed and removed work in progress Author opened the pull-request but it's still being worked on labels Feb 10, 2019
@gaearon
Copy link
Member

gaearon commented Feb 10, 2019

Надо еще заголовок поменять в content/docs/nav.yml

@lex111
Copy link
Member

lex111 commented Feb 10, 2019

Надо еще заголовок поменять в content/docs/nav.yml

О! Может добавить соответствующий пункт-чекбокс в шаблон пулреквеста?

@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

@gaearon готово c3708cc

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Хорошее начало, первые замечания:

  • мелкие отличия от терминологии
  • кавычки «»
  • местами, нагромождения существительных, которые читаются сложнее оригинального текста

Давайте поправим сначала эти проблемы. Я не читал до конца, т.к. в целом проблемы похожи, но когда поправите, почитаю ещё раз заново. Спасибо!

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

@gaearon @another-guy thanks guys for your feedback, please check out the updated version

Copy link
Member

@lex111 lex111 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • можно перевести текст в блоках кода

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

  • можно перевести текст в блоках кода

@lex111
В правилах указано:

Переводите комментарии в примерах кода, но не содержимое

@lex111
Copy link
Member

lex111 commented Feb 10, 2019

Мне кажется, лучше переводить, мы переводом единое руководство, где написано, что необязательно, но можно переводить, и поскольку на главной странице уже переведены надписи в примерах, то для согласованности предлагаю придерживаться этого варианта.

@agoldis
Copy link
Contributor Author

agoldis commented Feb 10, 2019

Хорошо, было бы здорово прояснить в правилах этот ньюанс :)

@lex111
Copy link
Member

lex111 commented Feb 10, 2019

Сделаем в #61

Copy link
Member

@gaearon gaearon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

В целом уже хорошо. Несколько замечаний, потом можно мержить. Большое спасибо;

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@agoldis
Copy link
Contributor Author

agoldis commented Feb 11, 2019

@gaearon спасибо за комментарии! ознакомься плз с новой версией

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved

4) Every second the browser calls the `tick()` method. Inside it, the `Clock` component schedules a UI update by calling `setState()` with an object containing the current time. Thanks to the `setState()` call, React knows the state has changed, and calls the `render()` method again to learn what should be on the screen. This time, `this.state.date` in the `render()` method will be different, and so the render output will include the updated time. React updates the DOM accordingly.
4) Таймер вызывает метод `tick()` ежесекундно. Часть метода — вызов `setState()` с объектом текущего времени — таким образом компонент `Clock` планирует обновление UI. Благодаря вызову `setState()` React знает, что состояние изменилось, и снова вызывает метод `render()`, чтобы узнать, что должно отображаться на экране. На этот раз `this.state.date` в методе `render()` будет другим, рендер компонента будет включать обновлённое время и React обновит DOM соответственно.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Часть метода — вызов setState() с объектом текущего времени — таким образом компонент Clock планирует обновление UI

Непонятная структура

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

рендер компонента будет включать обновлённое время и React обновит

Нужна запятая, сложное предложение

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gaearon посмотри пожалуйста новый вариант этого блока, я решил переписать после твоего отзыва. Спасибо!

content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
content/docs/state-and-lifecycle.md Outdated Show resolved Hide resolved
@agoldis
Copy link
Contributor Author

agoldis commented Feb 12, 2019

@gaearon @lex111 🛎

@gaearon gaearon merged commit 37897e1 into reactjs:master Feb 12, 2019
@gaearon
Copy link
Member

gaearon commented Feb 12, 2019

Отлично.

@gaearon gaearon mentioned this pull request Feb 12, 2019
agoldis added a commit to agoldis/ru.reactjs.org that referenced this pull request Feb 12, 2019
* upstream/master: (108 commits)
  Update nav
  Translation List and keys (reactjs#64)
  Translate "State and Lifecycle" (state-and-lifecycle.md) (reactjs#42)
  Add the term fallback
  Update getting-started.md
  Update getting-started.md
  Update TRANSLATION.md
  Update getting-started.md
  Update getting-started.md
  Update TRANSLATION.md
  Терминология: уборка
  Исправить Условный рендеринг в нав панели
  Пропущенное исправление в conditional-rendering
  Терминология: code splitting
  Терминология: helper
  Терминология child [component]
  Упорядочить глоссарий по алфавиту
  Больше исправлений по замечаниям касательно conditional-rendering
  Исправил PR-замечания про conditional-rendering.md
  Translate "Conditional Rendering" into Russian
  ...
@gcor
Copy link
Collaborator

gcor commented Feb 16, 2019

Правда там локальное должно быть внутренним.

@another-guy another-guy added needs proofread A read-through is still needed to release the document and removed needs review A pull request ready to be reviewed labels Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs proofread A read-through is still needed to release the document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants