Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Importing and exporting components #403

Merged
merged 6 commits into from Apr 26, 2023

Conversation

akcoren
Copy link
Contributor

@akcoren akcoren commented Apr 25, 2023

Translation has several commits. Corresponding page has several other components inside it. Those components are translated as well. MDXComponents.tsx is not totally translated.

Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler. 2 yer var sadece. Onlara da bakinca merge edelim.

src/content/learn/importing-and-exporting-components.md Outdated Show resolved Hide resolved
src/content/learn/importing-and-exporting-components.md Outdated Show resolved Hide resolved
@akcoren akcoren requested a review from alioguzhan April 26, 2023 06:50
Copy link
Member

@alioguzhan alioguzhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tesekkurler!

@github-actions
Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Three Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 76.09 KB (🟡 +150 B) 169.72 KB
/500 76.08 KB (🟡 +150 B) 169.71 KB
/[[...markdownPath]] 77.51 KB (🟡 +150 B) 171.14 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@alioguzhan alioguzhan merged commit 50043e6 into reactjs:main Apr 26, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants